[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region
From: |
Yoni Rabkin |
Subject: |
Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region |
Date: |
Sun, 07 Oct 2018 17:25:32 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
"Fran Burstall (Gmail)" <address@hidden> writes:
> On Sun, 7 Oct 2018 at 19:58, Yoni Rabkin <address@hidden> wrote:
>
> "Fran Burstall (Gmail)" <address@hidden> writes:
>
> > On Sat, 6 Oct 2018 at 09:11, Fran Burstall (Gmail) <
> > address@hidden> wrote:
> >
> >
> >
> > On Sat, 6 Oct 2018 at 03:31, Mike Kazantsev <
> address@hidden
> > > wrote:
> >
> > On Sat, 6 Oct 2018 00:03:59 +0100
> > Fran Burstall <address@hidden> wrote:
> >
> > > Have a look at a new version on the
> emms-playlist-limit
> > branch.
> > >
> > > Now "/ d" filters by regexp on what the playlist
> buffer
> > shows (strictly, on
> > > what `emms-track-description-function' returns for
> each
> > track). I hope
> > > this gives what Mike wants while addressing Yoni's
> concern.
> >
> > Indeed it works and is very useful, thanks!
> >
> > Also very intuitive to me how to use such limiting in
> > general,
> > as it's same pattern as with ibuffer and such using the
> /
> > key.
> >
> > One random small thing I've noticed at the top of "git
> log -u
> > origin/emms-playlist-limit":
> >
> > diff --git a/lisp/emms-playlist-limit.el b/lisp/
> > emms-playlist-limit.el
> > index 5f0cb28..9fcc74b 100644
> > --- a/lisp/emms-playlist-limit.el
> > +++ b/lisp/emms-playlist-limit.el
> > @@ -45,6 +45,7 @@
> > ;; / a emms-playlist-limit-to-info-artist
> > ;; / b emms-playlist-limit-to-info-album
> > ;; / c emms-playlist-limit-to-info-composer
> > +;; / d emms-playlist-limit-to-description
> > ;; / g emms-playlist-limit-to-info-genre
> > ;; / n emms-playlist-limit-to-name
> > ;; / p emms-playlist-limit-to-info-performer
> > @@ -79,11 +80,11 @@ the current playlist." attribute)
> >
> > ^^^ it looks like a tab slipped-in there among spaces
> or
> > vice-versa.
> >
> >
> > Well spotted. Now fixed.
> >
> >
> > OK to merge this into master?
>
> Please do.
>
>
> Done.
>
> Meanwhile, I was going to document emms-playlist-limit-to-description
> and was about to add to emms.texinfo:
>
> @item / d
> @kindex / d
> @findex emms-playlist-limit-to-description
> Create a new playlist buffer and populate it with tracks
> whose track description matches the given regular
> expression (default: the track description of the
> track at point).
>
> when I noticed that the other entries do not mention that the
> emms-playlist-limit-to-* functions take a regexp as argument.
>
> Was that deliberate to keep things short? Shall I follow suit?
Probably my oversight. Please add as much documentation as you can. The
manual is the long/tl;dr form.
Please make sure the file generates (makeinfo can be persnickety) after
editing.
thanks!
>
> ---Fran
>
>
--
"Cut your own wood and it will warm you twice"
- Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region, (continued)
- Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region, Fran Burstall, 2018/10/05
- Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region, Mike Kazantsev, 2018/10/05
- Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region, Yoni Rabkin, 2018/10/05
- Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region, Mike Kazantsev, 2018/10/05
- Message not available
- Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region, Fran Burstall, 2018/10/05
- Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region, Mike Kazantsev, 2018/10/05
- Message not available
- Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region, Fran Burstall (Gmail), 2018/10/06
- Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region, Fran Burstall (Gmail), 2018/10/07
- Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region, Yoni Rabkin, 2018/10/07
- Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region, Fran Burstall (Gmail), 2018/10/07
- Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region,
Yoni Rabkin <=
Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region, Fran Burstall, 2018/10/05