Re: PATCH allow explicit style= in #+cite_export: biblatex

[Pedro Andres Aranda Gutierrez]

Hopefully all remarks addressed..

Best, /PA

On Wed, 24 Apr 2024 at 19:05, Ihor Radchenko <yantar92@posteo.net> wrote:

Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:

> Oops, you are right. My local copy got a bit messed up.
>
> Here is a hopefully clean patch. I have tried it out on a local test-patch
> branch of current main and it applied.

Thanks!
May you also add NEWS entry?

Also, a few comments inline.

> Subject: [PATCH] Allow biblatex package options natively

Please, prefix the first line with oc-biblatex library name.

> lisp/oc-biblatex.el: detect and allow biblatex package options
>   in key=val,key=val,... format. <style>,key=val,key=val,...
>   continues to be supported and both formats are distinguished
> doc/org-manual.org: mention that biblatex options in 'native'
>   format are also supported. 

The changelog entries are not correctly formatted. See
https://orgmode.org/worg/org-contribute.html#commit-messages

Also, please start sentences from capital letter.

> --- a/doc/org-manual.org
> +++ b/doc/org-manual.org
> @@ -17631,7 +17631,9 @@ your LaTeX installation, it won't export to anything but PDF.
>  specifies the =biblatex= export processor with the default =numeric=
>  style and the =bibtex= backend. Always define the style first and then
>  the rest of load-time options for the =biblatex=
> -package. Alternatively, use the ~org-cite-biblatex-options~ variable
> +package. Alternatively, you can use the ~key=val,key=val~ format for
> +the options as documented in the =biblatex= package documentation, which
> +is also used for  the ~org-cite-biblatex-options~ variable
>  in your Emacs configuration. It will only export to PDF, since it
>  relies on the ~biblatex~ processor of your LaTeX installation;

It would be nice to add an example demonstrating the described behaviour.

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

--

Fragen sind nicht da, um beantwortet zu werden,

Fragen sind da um gestellt zu werden

Georg Kreisler

Headaches with a Juju log:

unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet

0001-Allow-native-biblatex-options-in-CITE_EXPORT.patch
Description: Text Data