[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] org.el: Fix newline at eob in org-insert-heading
From: |
Leo Vivier |
Subject: |
Re: [O] [PATCH] org.el: Fix newline at eob in org-insert-heading |
Date: |
Sat, 16 Feb 2019 10:31:19 +0100 |
Hello,
Nicolas Goaziou <address@hidden> writes:
>> The problem is due to `eobp' returning t when point is on the last
>> character of the narrowed buffer (as explained in its docstring).
>> Since those `eobp' predicates in `org-insert-heading' are probably
>> there to ensure a newline at the end of the *file*, checking whether
>> the buffer is *narrowed* (with `buffer-narrowed-p') prior to inserting
>> the newline fixes the problem.
>
> I don't think this would be a sufficient fix, because the buffer can be
> narrowed and, yet, showing the end of the file.
Yes, this is also something that I noticed, and I’d sent another patch
that address issue as a reply to the original email. However, not
knowing whether to submit the patch as is, squash it with the previous
one, or send it as a new thread altogether, I ended doing a clumsy job.
If you check it, you’ll see at the end of the commit message an appended
note on that issue.
> Anyway, I don't think this final newline is needed. I removed it. This
> should fix your issue. Please let me know if you encounter other
> glitches in that area.
Thank you. I’ll let you know if I encounter anything unexpected.
Best,
P.S.: I’d sent the patches with the wrong email. This is now resolved.
--
Leo Vivier
English Studies & General Linguistics
Master Student, English Department
Université Rennes 2