emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/devdocs ede749ddab: Fix bug introduced in d9e295a8


From: ELPA Syncer
Subject: [elpa] externals/devdocs ede749ddab: Fix bug introduced in d9e295a8
Date: Mon, 25 Mar 2024 06:57:52 -0400 (EDT)

branch: externals/devdocs
commit ede749ddab2a5a74a6ff927d7ad13cf2bf92ea76
Author: Augusto Stoffel <arstoffel@gmail.com>
Commit: Augusto Stoffel <arstoffel@gmail.com>

    Fix bug introduced in d9e295a8
---
 devdocs.el | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/devdocs.el b/devdocs.el
index 42c9fa86ff..30b6f96ac3 100644
--- a/devdocs.el
+++ b/devdocs.el
@@ -316,7 +316,9 @@ already installed, reinstall it."
   "Go to the original position in a DevDocs buffer."
   (interactive)
   (goto-char (point-min))
-  (when-let ((_ shr-target-id)
+  (when-let ((frag (let-alist (car devdocs--stack)
+                     (or .fragment (devdocs--path-fragment .path))))
+             (shr-target-id (url-unhex-string frag))
              (pred (if (fboundp 'shr--set-target-ids) #'member t)) ;; shr 
change in Emacs 29
              (match (text-property-search-forward 'shr-target-id shr-target-id 
pred)))
     (goto-char (prop-match-beginning match))))
@@ -484,22 +486,20 @@ fragment part of ENTRY.path."
             (file (expand-file-name (format "%s/%s.html"
                                             .doc.slug
                                             (url-hexify-string 
(devdocs--path-file .path)))
-                                    devdocs-data-dir))
-            (shr-target-id (when-let ((frag (or .fragment 
(devdocs--path-fragment .path))))
-                             (url-unhex-string frag))))
+                                    devdocs-data-dir)))
         (erase-buffer)
         ;; TODO: cl-progv here for shr settings?
         (shr-insert-document
          (with-temp-buffer
            (insert-file-contents file)
-           (libxml-parse-html-region (point-min) (point-max))))
-        (devdocs-goto-target))
+           (libxml-parse-html-region (point-min) (point-max)))))
       (set-buffer-modified-p nil)
       (setq-local devdocs-current-docs (list .doc.slug))
       (push entry devdocs--stack)
       (setq-local list-buffers-directory (format-mode-line devdocs-header-line
                                                            nil nil
                                                            (current-buffer)))
+      (devdocs-goto-target)
       (current-buffer))))
 
 (defun devdocs--revert-buffer (&rest _args)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]