emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/denote 111aea86ef 1/5: Clarify a comment about a possib


From: ELPA Syncer
Subject: [elpa] externals/denote 111aea86ef 1/5: Clarify a comment about a possible change to 'denote-directory' conditionality
Date: Sun, 25 Feb 2024 00:57:39 -0500 (EST)

branch: externals/denote
commit 111aea86ef596b6992c1538e7466ef2dae44397c
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Clarify a comment about a possible change to 'denote-directory' 
conditionality
---
 denote.el | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/denote.el b/denote.el
index 92b246d320..d0dc37c29f 100644
--- a/denote.el
+++ b/denote.el
@@ -690,7 +690,11 @@ Like `denote--completion-table' but also disable sorting."
   "Return path of variable `denote-directory' as a proper directory.
 Custom Lisp code can `let' bind the variable `denote-directory'
 to override what this function returns."
-  ;; TODO 2024-02-09: Remove this condition eventually.
+  ;; NOTE 2024-02-09: We may want to remove this condition eventually.
+  ;; The reason is that we want to stop supporting the dir-local
+  ;; values of `default-directory' or `local' in favour of just
+  ;; specifying a string.  I don't think we can delete this altogether
+  ;; though, as it will break existing configurations.
   (if-let (((or (eq denote-directory 'default-directory) (eq denote-directory 
'local)))
            (silo-dir (denote--default-directory-is-silo-p)))
       silo-dir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]