[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/helm ff9b346403 3/3: Don't overwrite the value of must-mat
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/helm ff9b346403 3/3: Don't overwrite the value of must-match when it is a function |
Date: |
Tue, 30 Jan 2024 10:00:02 -0500 (EST) |
branch: elpa/helm
commit ff9b346403c4ff08739a88bcb8377c723914526c
Author: Thierry Volpiatto <thievol@posteo.net>
Commit: Thierry Volpiatto <thievol@posteo.net>
Don't overwrite the value of must-match when it is a function
---
helm-mode.el | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/helm-mode.el b/helm-mode.el
index d03a53a56e..4e0444fb2c 100644
--- a/helm-mode.el
+++ b/helm-mode.el
@@ -810,8 +810,14 @@ that use `helm-comp-read'. See `helm-M-x' for example."
nil "Error: History should be specified as a symbol")
(when (get-buffer helm-action-buffer)
(kill-buffer helm-action-buffer))
- (unless (memq must-match '(confirm confirm-after-completion t nil))
- ;; Fix completing-read's using something else than `t' e.g. 1 or
+ ;; The value of MUST-MATCH is given to
+ ;; `helm--set-minibuffer-completion-confirm' which compute it and propagate
it
+ ;; to `minibuffer-completion-confirm' which is then used by
+ ;; `helm-confirm-and-exit-minibuffer'.
+ (unless (or (memq must-match '(confirm confirm-after-completion t nil))
+ (functionp must-match))
+ ;; Fix completing-read's using something else than (confirm
+ ;; confirm-after-completion t nil) or a function e.g. 1 or
;; whatever (bug #2527).
(setq must-match t))
(let ((action-fn `(("Sole action (Identity)"