emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/helm 24c0b673b5 2/3: Remove limitation of helm-always-two-


From: ELPA Syncer
Subject: [nongnu] elpa/helm 24c0b673b5 2/3: Remove limitation of helm-always-two-windows (#2635)
Date: Thu, 18 Jan 2024 03:59:58 -0500 (EST)

branch: elpa/helm
commit 24c0b673b5d1e8fc51de575e98653e58a9c747d3
Author: Thierry Volpiatto <thievol@posteo.net>
Commit: Thierry Volpiatto <thievol@posteo.net>

    Remove limitation of helm-always-two-windows (#2635)
    
    with helm-show-action-window-other-window.
    Same with helm--buffer-in-new-frame-p test which is not needed now we
    check the size of window.
---
 helm-core.el | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/helm-core.el b/helm-core.el
index 3df37c7710..e65db47ecb 100644
--- a/helm-core.el
+++ b/helm-core.el
@@ -1026,10 +1026,7 @@ Only async sources than use a sentinel calling
 
 If nil don't split and replace helm-buffer by the action buffer
 in same window.
-Possible value are left, right, below and above.
-Note that this may not fit well with some Helm window
-configurations, so it has effect only when
-`helm-always-two-windows' is non-nil."
+Possible value are left, right, below and above."
   :group 'helm
   :type '(choice
           (const :tag "Split at left" left)
@@ -5572,11 +5569,7 @@ Coerce source with coerce function."
   "Decide if window layout is suitable for showing action buffer.
 Note that the return value is meaningful only at some point in the code,
 i.e. before displaying action menu."
-  (when (and helm-show-action-window-other-window
-             ;; FIXME: now we check the window size, not sure this limitation 
is
-             ;; still needed (helm-always-two-windows).
-             (or helm-always-two-windows
-                 helm--buffer-in-new-frame-p))
+  (when helm-show-action-window-other-window
     ;; We were previously checking helm-split-window-state (eq vertical) to
     ;; decide to show action window, we now show it inconditionally in such 
case
     ;; but 'below'.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]