[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/ef-themes 6a14f45e58: STOP transient.el from trying to
From: |
ELPA Syncer |
Subject: |
[elpa] externals/ef-themes 6a14f45e58: STOP transient.el from trying to do semantic colouring |
Date: |
Sat, 9 Dec 2023 03:57:48 -0500 (EST) |
branch: externals/ef-themes
commit 6a14f45e587bd722f718f887ed2a87b583479a19
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
STOP transient.el from trying to do semantic colouring
Read the comment. We cannot give users this experience by default. I
shall review this once things change.
---
ef-themes.el | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/ef-themes.el b/ef-themes.el
index 5e9372921a..f20f8ae0ca 100644
--- a/ef-themes.el
+++ b/ef-themes.el
@@ -2166,7 +2166,18 @@ text should not be underlined as well) yet still blend
in."
`(transient-heading ((,c :inherit bold)))
`(transient-inactive-argument ((,c :inherit shadow)))
`(transient-inactive-value ((,c :inherit shadow)))
- `(transient-key ((,c :inherit ef-themes-key-binding)))
+ ;; NOTE 2023-12-09 10:30:09 +0200: The new user option
+ ;; `transient-semantic-coloring' is enabled by default. This is
+ ;; not good for us, because we are making it harder for users who
+ ;; need accessible colors to use the transient interfaces. I
+ ;; could set that user option to nil, but I think it is less
+ ;; intrusive to enforce uniformity among the relevant faces.
+ ;; Those who want semantic coloring can modify these faces.
+ `(transient-key ((,c :inherit modus-themes-key-binding)))
+ `(transient-key-exit ((,c :inherit modus-themes-key-binding)))
+ `(transient-key-noop ((,c :inherit (shadow modus-themes-key-binding))))
+ `(transient-key-return ((,c :inherit modus-themes-key-binding)))
+ `(transient-key-stay ((,c :inherit modus-themes-key-binding)))
`(transient-mismatched-key ((,c :underline t)))
`(transient-nonstandard-key ((,c :underline t)))
`(transient-pink ((,c :inherit bold :foreground ,magenta)))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [elpa] externals/ef-themes 6a14f45e58: STOP transient.el from trying to do semantic colouring,
ELPA Syncer <=