emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/transient 413310cd04 4/6: Define box line-width more ca


From: Jonas Bernoulli
Subject: [elpa] externals/transient 413310cd04 4/6: Define box line-width more carefully
Date: Sun, 3 Dec 2023 21:23:57 -0500 (EST)

branch: externals/transient
commit 413310cd049b176431527a1021e5b832e3ec6b5c
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    Define box line-width more carefully
    
    Before Emacs 28, the value had to be a number.  In Emacs 30 it can
    be a cons-cell of two numbers, but the manual says that it can still
    be a number.  But that doesn't seem to work for all Emacs releases
    in between, at least not when using a negative number.
    
    Try to cater to the preferences of various Emacs releases.
---
 lisp/transient.el | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lisp/transient.el b/lisp/transient.el
index ed05c2d777..348f885e44 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -498,7 +498,7 @@ See info node `(transient)Enabling and Disabling Suffixes'."
   :group 'transient-faces)
 
 (defface transient-higher-level
-  `((t (:box ( :line-width -1
+  `((t (:box ( :line-width ,(if (>= emacs-major-version 28) (cons -1 -1) -1)
                :color ,(face-attribute 'shadow :foreground nil t)))))
   "Face optionally used to highlight suffixes on higher levels.
 Also see option `transient-highlight-higher-levels'."
@@ -560,13 +560,15 @@ character used to separate possible values from each 
other."
   :group 'transient-faces)
 
 (defface transient-nonstandard-key
-  '((t (:box (:line-width -1 :color "cyan"))))
+  `((t (:box ( :line-width ,(if (>= emacs-major-version 28) (cons -1 -1) -1)
+               :color "cyan"))))
   "Face optionally used to highlight keys conflicting with short-argument.
 Also see option `transient-highlight-mismatched-keys'."
   :group 'transient-faces)
 
 (defface transient-mismatched-key
-  '((t (:box (:line-width -1 :color "magenta"))))
+  `((t (:box ( :line-width ,(if (>= emacs-major-version 28) (cons -1 -1) -1)
+               :color "magenta"))))
   "Face optionally used to highlight keys without a short-argument.
 Also see option `transient-highlight-mismatched-keys'."
   :group 'transient-faces)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]