[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/transient 425003a44b 22/41: transient-infix-set(argumen
From: |
Jonas Bernoulli |
Subject: |
[elpa] externals/transient 425003a44b 22/41: transient-infix-set(argument): Limit to other arguments |
Date: |
Sun, 12 Nov 2023 20:04:08 -0500 (EST) |
branch: externals/transient
commit 425003a44b8b716b200a81752192d7106f62d407
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
transient-infix-set(argument): Limit to other arguments
When checking whether other suffixes are incompatible (and this
method therefore has to disabled them) ignore all suffixes that are
not `transient-argument' objects. Previously we instead checked
whether they have an `argument' slot. (Which all `transient-infix'
do, for dubious reasons).
Since we only check for conflicts when an *argument* is enabled, it
makes sense if the other side of the comparison is also limited to
arguments. Besides, we cannot know what a potential conflict with
a non-argument would look like, and don't now what would have to be
done to detect it.
---
lisp/transient.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/transient.el b/lisp/transient.el
index cb51795384..842aab4d9c 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -3197,7 +3197,7 @@ prompt."
(remove arg rule)))
spec)))
(dolist (obj transient--suffixes)
- (when (and (slot-exists-p obj 'argument)
+ (when (and (cl-typep obj 'transient-argument)
(slot-boundp obj 'argument)
(member (oref obj argument) incomp))
(transient-infix-set obj nil)))))
- [elpa] externals/transient f769486803 02/41: Tweak some docstrings, (continued)
- [elpa] externals/transient f769486803 02/41: Tweak some docstrings, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 59d602a2e8 05/41: transient--refreshp: New variable, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 92572454b5 06/41: transient-toggle-level-limit: New command, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 8098d17518 13/41: transient--make-predicate-map: Fix handling of transient-suffix, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 10d590dc55 07/41: transient-echo-arguments: Also echo command keys, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient f43aee1a5e 08/41: transient--suffix-prototype: New function, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 9a7eb0d9a3 09/41: transient--make-predicate-map: Use define-key exclusively, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 67671e1ac0 12/41: transient--make-predicate-map: Rearrange pcase cases, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 5e841bb24b 19/41: transient-infix-set(argument): Replace :around with :after method, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient c6e3891537 21/41: transient-infix-set(argument): Cosmetics, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 425003a44b 22/41: transient-infix-set(argument): Limit to other arguments,
Jonas Bernoulli <=
- [elpa] externals/transient 8d8df0f038 20/41: transient-infix-set(argument): Cosmetics, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 9d9e931996 25/41: transient--shadowed-buffer: Renamed from transient--current-buffer, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 8e15a29b59 31/41: transient-format-description: Support function as value of face slot, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 533578b6b2 32/41: transient-information: Use a space as the fake key, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 59d8c0342a 18/41: transient--unset-incompatible: Remove unnecessary variable, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient ed5bd6fdc3 23/41: transient-infix-set(argument): Fix disabling incompatible options, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient bad91f79ec 29/41: transient-with-shadowed-buffer: Move definition, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient cf32cf6f98 39/41: transient--get-face: Favor face over function, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 4b9d831d28 10/41: transient--make-predicate-map: Drop obsolete condition, Jonas Bernoulli, 2023/11/12
- [elpa] externals/transient 784887b781 14/41: Account for t as transient-suffix for nested prefixes, Jonas Bernoulli, 2023/11/12