emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/transient 425003a44b 22/41: transient-infix-set(argumen


From: Jonas Bernoulli
Subject: [elpa] externals/transient 425003a44b 22/41: transient-infix-set(argument): Limit to other arguments
Date: Sun, 12 Nov 2023 20:04:08 -0500 (EST)

branch: externals/transient
commit 425003a44b8b716b200a81752192d7106f62d407
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    transient-infix-set(argument): Limit to other arguments
    
    When checking whether other suffixes are incompatible (and this
    method therefore has to disabled them) ignore all suffixes that are
    not `transient-argument' objects.  Previously we instead checked
    whether they have an `argument' slot.  (Which all `transient-infix'
    do, for dubious reasons).
    
    Since we only check for conflicts when an *argument* is enabled, it
    makes sense if the other side of the comparison is also limited to
    arguments.  Besides, we cannot know what a potential conflict with
    a non-argument would look like, and don't now what would have to be
    done to detect it.
---
 lisp/transient.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/transient.el b/lisp/transient.el
index cb51795384..842aab4d9c 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -3197,7 +3197,7 @@ prompt."
                                         (remove arg rule)))
                                  spec)))
     (dolist (obj transient--suffixes)
-      (when (and (slot-exists-p obj 'argument)
+      (when (and (cl-typep obj 'transient-argument)
                  (slot-boundp obj 'argument)
                  (member (oref obj argument) incomp))
         (transient-infix-set obj nil)))))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]