emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/popper ba7467b62b 010/102: More logic bugs fixed


From: ELPA Syncer
Subject: [elpa] externals/popper ba7467b62b 010/102: More logic bugs fixed
Date: Fri, 8 Sep 2023 15:58:50 -0400 (EDT)

branch: externals/popper
commit ba7467b62ba84177e28b3d0abc40c2a41b2a3c06
Author: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
Commit: Karthik Chikmagalur <karthikchikmagalur@gmail.com>

    More logic bugs fixed
    
    Fixed: Some funky bugs in the interaction of `popper-find-popups',
    `popper-update-popups' and `popper-raise-popup'.
    
    Basically it's difficult to predict when _exactly_
    `window-configuration-change-hook' runs, which was leading to all kinds of
    unpredictable behavior when turning popups into regular buffers and 
vice-versa.
---
 popper.el | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/popper.el b/popper.el
index 586827b8f1..e03281e4c5 100644
--- a/popper.el
+++ b/popper.el
@@ -56,7 +56,8 @@
 
 ;;; Code:
 
-(require 'cl-lib)
+(require 'cl-macs)
+(require 'cl-seq)
 (require 'subr-x)
 
 (defgroup popper nil
@@ -192,10 +193,10 @@ in the list of buffers TEST-BUFFER-LIST."
  Meant to be added to `window-configuration-change-hook'."
   (let* ((open-buffers (mapcar #'window-buffer (window-list)))
          (open-popups (popper-find-popups open-buffers))
-         (closed-popups (cl-remove-if
+         (closed-popups (cl-remove-if-not
                          (lambda (arg)
-                           (eq (buffer-local-value 'popper-popup-status (cdr 
arg))
-                               'raised))
+                           (memq (buffer-local-value 'popper-popup-status (cdr 
arg))
+                                 '(popup user-popup)))
                          (cl-set-difference popper-open-popup-alist open-popups
                           :test (lambda (arg1 arg2) (eql (cdr arg1) (cdr 
arg2)))))))
          (setq popper-open-popup-alist (nreverse open-popups))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]