emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/devil 887c47d7ee 2/2: Revert devil-translations to constru


From: ELPA Syncer
Subject: [nongnu] elpa/devil 887c47d7ee 2/2: Revert devil-translations to constructed list
Date: Sun, 13 Aug 2023 18:59:10 -0400 (EDT)

branch: elpa/devil
commit 887c47d7ee6bd240698c5ab8b4b73a589c4988d0
Author: Susam Pal <susam@susam.net>
Commit: Susam Pal <susam@susam.net>

    Revert devil-translations to constructed list
    
    Commit e0a12cd changed the default value of devil-translations to a
    quoted list.  However, that change now appears to be misguided because
    a user may have existing configuration that modifies this list.
    Therefore revert the value of this variable from a quoted list to a
    list constructed with the list function.
    
    Thanks to Morgan Willcock for reviewing the earlier commit and
    pointing this issue out.
---
 README.org |  1 +
 devil.el   | 14 +++++++-------
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/README.org b/README.org
index 728530225c..91f9304ecb 100644
--- a/README.org
+++ b/README.org
@@ -80,6 +80,7 @@ Thanks to:
 
 - [[https://github.com/riscy][Chris Rayner]] for initial code review.
 - [[https://github.com/phikal][Philip Kaludercic]] for initial code review and 
patches.
+- [[https://github.com/morganwillcock][Morgan Willcock]] for initial feedback 
and code reviews.
 
 ** Reactions
 :PROPERTIES:
diff --git a/devil.el b/devil.el
index b6a1d00030..53014c7ee0 100644
--- a/devil.el
+++ b/devil.el
@@ -141,13 +141,13 @@ supported by `devil-format' may be used in the keys."
   :type '(alist :key-type string :value-type function))
 
 (defcustom devil-translations
-  '(("%k m m" . "C-M-")
-    ("%k m %k" . "M-,")
-    ("%k m z" . "M-")
-    ("%k m" . "M-")
-    ("%k %k" . "%k")
-    ("%k z" . "C-")
-    ("%k" . "C-"))
+  (list (cons "%k m m" "C-M-")
+        (cons "%k m %k" "M-,")
+        (cons "%k m z" "M-")
+        (cons "%k m" "M-")
+        (cons "%k %k" "%k")
+        (cons "%k z" "C-")
+        (cons "%k"  "C-"))
   "Translation rules to convert Devil input to Emacs key sequence.
 
 The value of this variable is an alist where each item represents



reply via email to

[Prev in Thread] Current Thread [Next in Thread]