emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/websocket 9d938e9003 1/3: Remove the remote test depend


From: ELPA Syncer
Subject: [elpa] externals/websocket 9d938e9003 1/3: Remove the remote test dependent on echo.websocket.org
Date: Wed, 9 Aug 2023 00:59:04 -0400 (EDT)

branch: externals/websocket
commit 9d938e90030781b6b34a74ade1c901636b5e6502
Author: Andrew Hyatt <ahyatt@gmail.com>
Commit: Andrew Hyatt <ahyatt@gmail.com>

    Remove the remote test dependent on echo.websocket.org
    
    The canonical test, echo.websocket.org, has been shut off.
---
 websocket-functional-test.el | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/websocket-functional-test.el b/websocket-functional-test.el
index 8a599d043d..8fbcdf3d8b 100644
--- a/websocket-functional-test.el
+++ b/websocket-functional-test.el
@@ -65,9 +65,7 @@ written to be used widely."
     (websocket-close wstest-ws)))
 
 (ert-deftest websocket-client-with-local-server ()
-  ;; If testserver.py cannot start, this test will fail. In general, if you
-  ;; don't care about avoiding outside connections, the remote server variant 
is
-  ;; usually easier to run, and tests the same things..
+  ;; If testserver.py cannot start, this test will fail.
   (let ((proc (start-process
                "websocket-testserver" "*websocket-testserver*"
                "python3" "testserver.py" "--log_to_stderr" "--logging=debug")))
@@ -75,12 +73,6 @@ written to be used widely."
       (sleep-for 1)
       (websocket-functional-client-test "ws://127.0.0.1:9999"))))
 
-(ert-deftest websocket-client-with-remote-server ()
-  ;; Emacs previous to Emacs 24 cannot handle wss.
-  (if (>= (string-to-number (substring emacs-version 0 2)) 24)
-      (websocket-functional-client-test "wss://echo.websocket.org")
-    (websocket-functional-client-test "ws://echo.websocket.org")))
-
 (ert-deftest websocket-server ()
   (let* ((wstest-closed)
          (wstest-msg)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]