[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/org-remark ef7e02d542 34/67: fix: annotation body to be
From: |
ELPA Syncer |
Subject: |
[elpa] externals/org-remark ef7e02d542 34/67: fix: annotation body to be nil when no body text |
Date: |
Sat, 22 Jul 2023 06:59:02 -0400 (EDT) |
branch: externals/org-remark
commit ef7e02d54261451da0339da02440567810ea4f0e
Author: Noboru Ota <me@nobiot.com>
Commit: Noboru Ota <me@nobiot.com>
fix: annotation body to be nil when no body text
Before this fix, the annotation body always contained "[empty text]". We
will change this to make it nil when there is no annotation body text.
---
org-remark.el | 37 +++++++++++++++++++------------------
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/org-remark.el b/org-remark.el
index 0d617ce971..f12ff61480 100644
--- a/org-remark.el
+++ b/org-remark.el
@@ -6,7 +6,7 @@
;; URL: https://github.com/nobiot/org-remark
;; Version: 1.1.0
;; Created: 22 December 2020
-;; Last modified: 25 June 2023
+;; Last modified: 02 July 2023
;; Package-Requires: ((emacs "27.1") (org "9.4"))
;; Keywords: org-mode, annotation, note-taking, marginal-notes, wp,
@@ -1199,7 +1199,7 @@ properties, add prefix \"*\"."
;; (org-end-of-meta-data :full) took us to next org heading):
(or (looking-at org-heading-regexp)
(eobp)) ;; end of buffer
- "[empty entry]"
+ nil ;; no body text for the annotation
(buffer-substring-no-properties
(point)
(org-end-of-subtree))))))
@@ -1279,22 +1279,23 @@ highlight is a property list in the following
properties:
;; Headline levels now can be dynamically changed via
;; `org-remark-notes-headline-functions'
(while (not (org-next-visible-heading 1))
- (when-let ((id (org-entry-get (point) org-remark-prop-id))
- (beg (string-to-number
- (org-entry-get (point)
- org-remark-prop-source-beg)))
- (end (string-to-number
- (org-entry-get (point)
- org-remark-prop-source-end)))
- (body (org-remark-notes-get-body)))
- (push (list :id id
- :location (cons beg end)
- :label (org-entry-get (point)
"org-remark-label")
- :props (list
- :original-text
- (org-entry-get (point)
"org-remark-original-text")
- :body body))
- highlights))))
+ (let ((id (org-entry-get (point) org-remark-prop-id))
+ (beg (string-to-number
+ (org-entry-get (point)
+ org-remark-prop-source-beg)))
+ (end (string-to-number
+ (org-entry-get (point)
+ org-remark-prop-source-end)))
+ (body (org-remark-notes-get-body)))
+ (when (and id beg end)
+ (push (list :id id
+ :location (cons beg end)
+ :label (org-entry-get (point)
"org-remark-label")
+ :props (list
+ :original-text
+ (org-entry-get (point)
"org-remark-original-text")
+ :body body))
+ highlights)))))
highlights))))))
(defvar org-remark-highlights-after-load-hook nil
- [elpa] externals/org-remark 36df818752 55/67: docs: Update user manaul, (continued)
- [elpa] externals/org-remark 36df818752 55/67: docs: Update user manaul, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 642d4b489f 13/67: docs: updated NEWS, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 2a10b3d75a 17/67: refactor: adjust-positions, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 09d95e7519 20/67: Merge branch 'main' into dev/nov.el, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 52bc575bb9 28/67: docs: comments and docstring, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark e10a00b426 35/67: feat: add icon for highlights with annotation body text #64, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 41f90c53a8 59/67: refactor: Add 'org-remark-string=' for highlight-adjust-positions, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 2bd53de493 60/67: refactor: Set fn to hook org-remark-highlights-after-load-functions, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark e1b7a3a1ba 19/67: Merge remote-tracking branch 'sati-bodhi/main' into dev/nov.el, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 090156bed2 21/67: feat: org-remark-nov-mode minor mode, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark ef7e02d542 34/67: fix: annotation body to be nil when no body text,
ELPA Syncer <=
- [elpa] externals/org-remark aa58058ec4 38/67: refactor: add-headlines (WIP), ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark c38f46e806 42/67: refactor(highlight-add): remove spurflous/obsolete elements, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark b94c64e381 45/67: feature: Make icons customizable, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark f1ea78bcf1 47/67: refactor: highlight-add, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark f21ab48aad 62/67: refactor: simple name replace org-remark-get-epub-source, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 160de610f8 64/67: fix: make sure new top-level headline is appended, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark fea8103b9b 65/67: fix(legacy): compilation warning #66, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 32149d5135 25/67: fix: Exclude pdfs from default file type #57, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 14996bc1ce 30/67: refactor: notes-set-properties & new-headline, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 356c87468a 31/67: feature(nov) find-source and link correctly (WIP), ELPA Syncer, 2023/07/22