emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/dired-preview 959299b18a 39/67: Add FIXME for dired-pre


From: ELPA Syncer
Subject: [elpa] externals/dired-preview 959299b18a 39/67: Add FIXME for dired-preview-return-window-size
Date: Sat, 8 Jul 2023 15:57:54 -0400 (EDT)

branch: externals/dired-preview
commit 959299b18acc25df3d4302fd3d69e7d814ad4f78
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Add FIXME for dired-preview-return-window-size
---
 dired-preview.el | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/dired-preview.el b/dired-preview.el
index 97bbf86545..0983f6a380 100644
--- a/dired-preview.el
+++ b/dired-preview.el
@@ -179,6 +179,10 @@ DIMENSION is either a `:width' or `:height' keyword.  It is
 checked against `split-width-threshold' or
 `split-height-threshold'"
   (pcase dimension
+    ;; FIXME 2023-07-03: In both cases, this assumes that the "else"
+    ;; result is smaller than the "then".  This is not a given though,
+    ;; because we do not know the result of the calculation ahead of
+    ;; time.
     (:width (if (>= (* fill-column 2) split-width-threshold)
                 fill-column
               (- (window-body-width) fill-column)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]