[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/dired-preview e2da14de12 30/67: Fix scope of action to
From: |
ELPA Syncer |
Subject: |
[elpa] externals/dired-preview e2da14de12 30/67: Fix scope of action to close preview upon buffer switch |
Date: |
Sat, 8 Jul 2023 15:57:53 -0400 (EDT) |
branch: externals/dired-preview
commit e2da14de126e6ac281b5ef13aec6f74fadec2a43
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
Fix scope of action to close preview upon buffer switch
Thanks to Bruno Boal for taking a look into this with me:
<https://git.sr.ht/~bboal>. This was done in a private channel and
the information is shared with permission.
---
dired-preview.el | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/dired-preview.el b/dired-preview.el
index 3df6f85005..4ccaa827c9 100644
--- a/dired-preview.el
+++ b/dired-preview.el
@@ -232,7 +232,8 @@ conforms with `dired-preview--preview-p'."
(defun dired-preview--close-previews-outside-dired ()
"Call `dired-preview--close-previews' if BUFFER is not in Dired mode."
(when (not (eq major-mode 'dired-mode))
- (dired-preview--close-previews)))
+ (dired-preview--close-previews)
+ (remove-hook 'window-state-change-hook
#'dired-preview--close-previews-outside-dired)))
;; NOTE 2023-06-29: See the FIXME for `dired-preview-display-action-alist'.
(defun dired-preview-set-up-preview-window (window &rest _)
@@ -241,10 +242,7 @@ Use this as the `body-function' in the user option
`dired-preview-display-action-alist'."
(set-window-parameter window 'dired-preview-window :preview)
(with-current-buffer (window-buffer window)
- ;; FIXME 2023-06-30: This is the wrong scope, because it will not
- ;; be relevant when using `switch-to-buffer', `previous-buffer',
- ;; etc. Basically, it assumes we are in a Dired-only environment.
- (add-hook 'post-command-hook #'dired-preview--close-previews-outside-dired
nil :local)))
+ (add-hook 'window-state-change-hook
#'dired-preview--close-previews-outside-dired)))
(defun dired-preview--display-buffer (buffer)
"Call `display-buffer' for BUFFER.
- [elpa] externals/dired-preview ae937209cc 03/67: add advice to dired-mark to preview the current file, (continued)
- [elpa] externals/dired-preview ae937209cc 03/67: add advice to dired-mark to preview the current file, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview 80a2233cca 16/67: Update a couple of doc strings, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview 1d3befd70c 20/67: Make sure to unset delayed-mode-hooks after they are ran, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview bf25ef53e1 23/67: Run the preview on an idle timer, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview 3ba4c3f533 25/67: Add FIXME to preview only when it is still the current one, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview 837d3c7e94 14/67: Rename private function, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview 8d545491d4 05/67: Update documentation to match commit 3304286 (command+keymap removal), ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview a653299672 09/67: Do not preview already visible file, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview 16a2e9e835 18/67: Fix test for current command in dired-preview-trigger, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview 5ffcfb0c85 24/67: Tweak the format of the timer call, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview e2da14de12 30/67: Fix scope of action to close preview upon buffer switch,
ELPA Syncer <=
- [elpa] externals/dired-preview 75f1b11e99 29/67: Add FIXME for the scope of dired-preview--close-previews-outside-dired, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview 3f2588abb3 32/67: Make all preview state be handled by the trigger, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview 49bea8f6d4 34/67: Delete windows, then kill buffers, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview 070f02a1b0 42/67: Stop changing the mode-line-format, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview 5338f5c1a7 26/67: Make commit 3ba4c3f more resilient, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview ec09d4b856 27/67: Fix how delayed-mode-hooks are handled, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview b367550663 28/67: Rewrite how the timer is started, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview c20af9c9eb 31/67: Fix how the window is set up and closed outside Dired, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview 8c1c73716e 37/67: Tighten the event loop to avoid inconsistencies, ELPA Syncer, 2023/07/08
- [elpa] externals/dired-preview 18b607fc48 40/67: Simplify dired-preview-return-window-size, ELPA Syncer, 2023/07/08