[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/websocket 36deb3ff85 106/114: Remove `websocket-ensure-
From: |
ELPA Syncer |
Subject: |
[elpa] externals/websocket 36deb3ff85 106/114: Remove `websocket-ensure-connected'. |
Date: |
Wed, 15 Feb 2023 20:59:04 -0500 (EST) |
branch: externals/websocket
commit 36deb3ff85368d000a88435d5a645ffbab490654
Author: ahyatt <ahyatt@penguin>
Commit: ahyatt <ahyatt@penguin>
Remove `websocket-ensure-connected'.
Re-opening a websocket can be a problem if the connection failed due to
repeatable reasons, such as authentication failures. It also leads to
strange
situations where the websocket the client has is not a valid websocket
anymore.
I suspect this isn't actually used.
---
websocket.el | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/websocket.el b/websocket.el
index 56f768855e..4bfa0baab6 100644
--- a/websocket.el
+++ b/websocket.el
@@ -557,7 +557,6 @@ the `websocket-error' condition."
(websocket-debug websocket "Sending frame, opcode: %s payload: %s"
(websocket-frame-opcode frame)
(websocket-frame-payload frame))
- (websocket-ensure-connected websocket)
(unless (websocket-openp websocket)
(signal 'websocket-closed (list frame)))
(process-send-string (websocket-conn websocket)
@@ -581,21 +580,6 @@ the `websocket-error' condition."
(setf (websocket-ready-state websocket) 'closed))
(delete-process (websocket-conn websocket)))
-(defun websocket-ensure-connected (websocket)
- "If the WEBSOCKET connection is closed, open it."
- (unless (and (websocket-conn websocket)
- (cl-ecase (process-status (websocket-conn websocket))
- ((run open listen) t)
- ((stop exit signal closed connect failed nil) nil)))
- (websocket-close websocket)
- (websocket-open (websocket-url websocket)
- :protocols (websocket-protocols websocket)
- :extensions (websocket-extensions websocket)
- :on-open (websocket-on-open websocket)
- :on-message (websocket-on-message websocket)
- :on-close (websocket-on-close websocket)
- :on-error (websocket-on-error websocket))))
-
;;;;;;;;;;;;;;;;;;;;;;
;; Websocket client ;;
;;;;;;;;;;;;;;;;;;;;;;
- [elpa] externals/websocket fa751be5b7 083/114: Add new test for correct websocket frame encoding., (continued)
- [elpa] externals/websocket fa751be5b7 083/114: Add new test for correct websocket frame encoding., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket d91a9aef5a 084/114: Update version to 1.11.1., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 5be01c6d1a 085/114: Accept a common variation of the websocket header., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 491a60b8bb 086/114: Set version to 1.12., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 74e4b82bf1 087/114: Fix GPL 2/3 discrepancy by making the .el files match the license., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 69ee80a88b 088/114: Modernize & rewrite functional tests as ert tests., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 992ef33e46 089/114: Fix `process-status` returns `'connect` when nowait, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 74f00575b9 091/114: Make condition more readable, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 078f83902c 096/114: Merge pull request #68 from xhcoding/master, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 2c576b6cb8 113/114: Sets version to 1.14, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 36deb3ff85 106/114: Remove `websocket-ensure-connected'.,
ELPA Syncer <=
- [elpa] externals/websocket fda4455333 109/114: Merge pull request #78 from ThomasFKJorna/patch-1, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 4fb51115f0 005/114: Add extra assert in functional test, and increase sleep time for wss test., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket be99c4636a 097/114: Add warning about missing master branch., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket fe7b0bc2c3 099/114: resurrect testserver.py, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 341ec2b9d6 102/114: Replace obsolete flet macro., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 5aaf9d1206 104/114: Make the localhost-based test compatible with ert., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 2c923eba75 114/114: Merge branch 'externals/websocket' of https://git.sv.gnu.org/git/emacs/elpa, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 34e11124fd 107/114: Set version to 1.13., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 31e122a9d7 094/114: Merge pull request #67 from xuchunyang/patch-2, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 06dcb68721 095/114: fix QWebsocketServer may send RST during handshake, ELPA Syncer, 2023/02/15