[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/embark 4882b395ce 2/2: Merge pull request #593 from min
From: |
ELPA Syncer |
Subject: |
[elpa] externals/embark 4882b395ce 2/2: Merge pull request #593 from minad/use-revert-function |
Date: |
Thu, 2 Feb 2023 18:57:38 -0500 (EST) |
branch: externals/embark
commit 4882b395cef98a517d530ffe483aa0dc7201158c
Merge: 3f2a7c47e6 83838fc948
Author: Omar AntolĂn Camarena <omar.antolin@gmail.com>
Commit: GitHub <noreply@github.com>
Merge pull request #593 from minad/use-revert-function
Do not install a global advice on tabulated-list-revert
---
embark.el | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/embark.el b/embark.el
index 28a5c2447a..f9c8165b91 100644
--- a/embark.el
+++ b/embark.el
@@ -2528,14 +2528,6 @@ This is only used for annotation that are not already
fontified.")
(defvar-local embark--rerun-function nil
"Function to rerun the collect or export that made the current buffer.")
-(defun embark-collect--post-revert (&rest _)
- "Run `embark-collect-post-revert-hook'.
-This function is used as :after advice for `tabulated-list-revert'."
- (when (derived-mode-p 'embark-collect-mode)
- (run-hooks 'embark-collect-post-revert-hook)))
-
-(advice-add 'tabulated-list-revert :after #'embark-collect--post-revert)
-
(autoload 'package-delete "package")
(declare-function package--from-builtin "package")
(declare-function package-desc-extras "package")
@@ -2812,6 +2804,11 @@ perhaps editing the minibuffer contents, and, if you
wish, you
can rerun `embark-collect' to get an updated buffer."
:interactive nil :abbrev-table nil :syntax-table nil)
+(defun embark-collect--revert (&rest _)
+ "Revert function of `embark-collect-mode' buffers."
+ (tabulated-list-revert)
+ (run-hooks 'embark-collect-post-revert-hook))
+
(defun embark-collect--remove-zebra-stripes ()
"Remove highlighting of alternate rows."
(remove-overlays nil nil 'face 'embark-collect-zebra-highlight))
@@ -3022,7 +3019,8 @@ buffer has a unique name."
(with-current-buffer buffer
(setq tabulated-list-use-header-line nil ; default to no header
header-line-format nil
- tabulated-list--header-string nil)
+ tabulated-list--header-string nil
+ revert-buffer-function #'embark-collect--revert)
(setq embark--rerun-function rerun)
(local-set-key [remap revert-buffer] #'embark-rerun-collect-or-export)
(when (memq embark--type embark-collect-zebra-types)
@@ -3031,7 +3029,7 @@ buffer has a unique name."
(let ((window (display-buffer buffer)))
(with-selected-window window
(run-mode-hooks)
- (tabulated-list-revert))
+ (embark-collect--revert))
(set-window-dedicated-p window t)
buffer)))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [elpa] externals/embark 4882b395ce 2/2: Merge pull request #593 from minad/use-revert-function,
ELPA Syncer <=