emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 0c55261971b 1/2: Make lexical-binding cookie warning test more ro


From: Mattias Engdegård
Subject: master 0c55261971b 1/2: Make lexical-binding cookie warning test more robust
Date: Wed, 3 Apr 2024 05:31:38 -0400 (EDT)

branch: master
commit 0c55261971b0fea62a8e94204e544ff8af714a2e
Author: Mattias Engdegård <mattiase@acm.org>
Commit: Mattias Engdegård <mattiase@acm.org>

    Make lexical-binding cookie warning test more robust
    
    * test/lisp/emacs-lisp/bytecomp-tests.el
    (bytecomp-tests--lexical-binding-cookie):
    Run with lexical-binding both on and off.
---
 test/lisp/emacs-lisp/bytecomp-tests.el | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/test/lisp/emacs-lisp/bytecomp-tests.el 
b/test/lisp/emacs-lisp/bytecomp-tests.el
index 26408e8685a..a943012e5fc 100644
--- a/test/lisp/emacs-lisp/bytecomp-tests.el
+++ b/test/lisp/emacs-lisp/bytecomp-tests.el
@@ -1348,12 +1348,14 @@ byte-compiled.  Run with dynamic binding."
               (string-search
                "file has no `lexical-binding' directive on its first line"
                (bytecomp-tests--log-from-compilation source))))
-    (let ((some-code "(defun my-fun () 12)\n"))
-      (should-not (cookie-warning
-                   (concat ";;; -*-lexical-binding:t-*-\n" some-code)))
-      (should-not (cookie-warning
-                   (concat ";;; -*-lexical-binding:nil-*-\n" some-code)))
-      (should (cookie-warning some-code)))))
+    (dolist (lb '(t nil))
+      (let ((lexical-binding lb)
+            (some-code "(defun my-fun () 12)\n"))
+        (should-not (cookie-warning
+                     (concat ";;; -*-lexical-binding:t-*-\n" some-code)))
+        (should-not (cookie-warning
+                     (concat ";;; -*-lexical-binding:nil-*-\n" some-code)))
+        (should (cookie-warning some-code))))))
 
 (ert-deftest bytecomp-tests--unescaped-char-literals ()
   "Check that byte compiling warns about unescaped character



reply via email to

[Prev in Thread] Current Thread [Next in Thread]