emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master c49f5d5: Fix gnus-group-describe-all-groups (bug#35


From: Basil L. Contovounesios
Subject: [Emacs-diffs] master c49f5d5: Fix gnus-group-describe-all-groups (bug#35233)
Date: Sat, 13 Apr 2019 21:03:25 -0400 (EDT)

branch: master
commit c49f5d573b37f7aaa8d480d568c7e26d975f0320
Author: Basil L. Contovounesios <address@hidden>
Commit: Basil L. Contovounesios <address@hidden>

    Fix gnus-group-describe-all-groups (bug#35233)
    
    This fixes oversights from
    2018-04-26T16:26:27-07:address@hidden and
    2016-02-13T18:45:11+11:address@hidden
    * lisp/gnus/gnus-group.el (gnus-group-describe-all-groups): Insert
    group name and description instead of group name twice.  Do not pass
    a hash-table to intern.  Call sort with correct number of arguments.
---
 lisp/gnus/gnus-group.el | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index 0956dc4..b1e4091 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -4137,20 +4137,19 @@ If DONT-SCAN is non-nil, scan non-activated groups as 
well."
   (when (not (or gnus-description-hashtb
                 (gnus-read-all-descriptions-files)))
     (error "Couldn't request descriptions file"))
-  (let ((buffer-read-only nil)
-       (groups (sort (hash-table-keys gnus-description-hashtb)))
-       b)
+  (let ((buffer-read-only nil))
     (erase-buffer)
-    (dolist (group groups)
-      (setq b (point))
-      (let ((charset (gnus-group-name-charset nil group)))
+    (dolist (group (sort (hash-table-keys gnus-description-hashtb) #'string<))
+      (let ((b (point))
+            (desc (gethash group gnus-description-hashtb))
+            (charset (gnus-group-name-charset nil group)))
        (insert (format "      *: %-20s %s\n"
                        (gnus-group-name-decode group charset)
-                       (gnus-group-name-decode group charset))))
-      (add-text-properties
-       b (1+ b) (list 'gnus-group (intern group gnus-description-hashtb)
-                     'gnus-unread t 'gnus-marked nil
-                     'gnus-level (1+ gnus-level-subscribed))))
+                        (gnus-group-name-decode desc charset)))
+        (add-text-properties
+         b (1+ b) (list 'gnus-group group
+                        'gnus-unread t 'gnus-marked nil
+                        'gnus-level (1+ gnus-level-subscribed)))))
     (goto-char (point-min))
     (gnus-group-position-point)))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]