[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] master e1a457e: ; Warn of while/dolist pitfall in gnus-sum
From: |
Basil L. Contovounesios |
Subject: |
[Emacs-diffs] master e1a457e: ; Warn of while/dolist pitfall in gnus-sum.el |
Date: |
Tue, 9 Apr 2019 11:37:21 -0400 (EDT) |
branch: master
commit e1a457e63530cd566a1bc2957b70221bb6f76984
Author: Basil L. Contovounesios <address@hidden>
Commit: Basil L. Contovounesios <address@hidden>
; Warn of while/dolist pitfall in gnus-sum.el
Suggested by Andy Moreton in the following thread:
https://lists.gnu.org/archive/html/emacs-devel/2019-04/msg00294.html
* lisp/gnus/gnus-sum.el (gnus-summary-move-article): Add comment
warning of common while/dolist pitfall. (bug#33653#134)
---
lisp/gnus/gnus-sum.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index 8959a2b..b8aa302 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -10088,6 +10088,7 @@ ACTION can be either `move' (the default), `crosspost'
or `copy'."
(or (car select-method)
(gnus-group-decoded-name to-newsgroup))
articles)
+ ;; This `while' is not equivalent to a `dolist' (bug#33653#134).
(while articles
(setq article (pop articles))
;; Set any marks that may have changed in the summary buffer.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] master e1a457e: ; Warn of while/dolist pitfall in gnus-sum.el,
Basil L. Contovounesios <=