emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 2bedd23 09/28: Update expectations for JSX indentat


From: Jackson Ray Hamilton
Subject: [Emacs-diffs] master 2bedd23 09/28: Update expectations for JSX indentation in JSXAttribute space
Date: Tue, 9 Apr 2019 02:00:13 -0400 (EDT)

branch: master
commit 2bedd23358d2d7378eec78d526ba1435d3b4d122
Author: Jackson Ray Hamilton <address@hidden>
Commit: Jackson Ray Hamilton <address@hidden>

    Update expectations for JSX indentation in JSXAttribute space
    
    * test/manual/indent/js-jsx.js: Align expectations for dangling
    closing constructs with other places in the tests.
---
 test/manual/indent/js-jsx.js | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/test/manual/indent/js-jsx.js b/test/manual/indent/js-jsx.js
index af3c340..2ec00c6 100644
--- a/test/manual/indent/js-jsx.js
+++ b/test/manual/indent/js-jsx.js
@@ -37,7 +37,7 @@ return (
 
 React.render(
   <input
-    />,
+  />,
   {
     a: 1
   }
@@ -242,12 +242,18 @@ export default ({ stars }) => (
 
 // JS expressions should not break indentation
 // (https://github.com/mooz/js2-mode/issues/462).
+//
+// In the referenced issue, the user actually wanted indentation which
+// was simply different than Emacs’ SGML attribute indentation.
+// Nevertheless, his issue highlighted our inability to properly
+// indent code with JSX inside JSXExpressionContainers inside JSX.
 return (
   <Router>
     <Bar>
-      <Route exact path="/foo" render={() => (
-        <div>nothing</div>
-      )} />
+      <Route exact path="/foo"
+             render={() => (
+               <div>nothing</div>
+             )} />
       <Route exact path="/bar" />
     </Bar>
   </Router>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]