[Emacs-diffs] emacs-26 3cba92d: Fix faces in compilation messages

[Eli Zaretskii]

branch: emacs-26
commit 3cba92d42ecf2156296b5f05c07a3d1ded78218e
Author: Daniel Lopez <address@hidden>
Commit: Eli Zaretskii <address@hidden>

    Fix faces in compilation messages
    
    * lisp/progmodes/compile.el (compilation-parse-errors): Don't
    clobber the value of TYPE inside the loop.  (Bug#34479)
    
    Copyright-paperwork-exempt: yes
---
 lisp/progmodes/compile.el | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index a5dcbd7..5312a55 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -1429,17 +1429,17 @@ to `compilation-error-regexp-alist' if RULES is nil."
                              file line end-line col end-col (or type 2) fmt))
 
             (when (integerp file)
-              (setq type (if (consp type)
-                             (compilation-type type)
-                           (or type 2)))
-              (compilation--note-type type)
-
-              (compilation--put-prop
-               file 'font-lock-face
-               (symbol-value (aref [compilation-info-face
-                                    compilation-warning-face
-                                    compilation-error-face]
-                                   type))))
+              (let ((this-type (if (consp type)
+                                   (compilation-type type)
+                                 (or type 2))))
+                (compilation--note-type type)
+
+                (compilation--put-prop
+                 file 'font-lock-face
+                 (symbol-value (aref [compilation-info-face
+                                      compilation-warning-face
+                                      compilation-error-face]
+                                     this-type)))))
 
             (compilation--put-prop
              line 'font-lock-face compilation-line-face)