[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] master dc3f70d: Skip a remote filenotify test on hydra
From: |
Glenn Morris |
Subject: |
[Emacs-diffs] master dc3f70d: Skip a remote filenotify test on hydra |
Date: |
Wed, 19 Dec 2018 02:21:51 -0500 (EST) |
branch: master
commit dc3f70dc8f87a379cd418b96a5750765a27f8abd
Author: Glenn Morris <address@hidden>
Commit: Glenn Morris <address@hidden>
Skip a remote filenotify test on hydra
* test/lisp/filenotify-tests.el (file-notify--deftest-remote):
Add optional argument to skip test.
(file-notify-test07-many-events-remote): Skip on hydra.nixos.org.
---
test/lisp/filenotify-tests.el | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/test/lisp/filenotify-tests.el b/test/lisp/filenotify-tests.el
index 48dd2de..4c8e7fb 100644
--- a/test/lisp/filenotify-tests.el
+++ b/test/lisp/filenotify-tests.el
@@ -241,13 +241,14 @@ This returns only for the local case and gfilenotify;
otherwise it is nil.
(gfile-monitor-name file-notify--test-desc)))
(cdr (assq file-notify--test-desc file-notify--test-monitors))))))
-(defmacro file-notify--deftest-remote (test docstring &optional expected)
+(defmacro file-notify--deftest-remote (test docstring &optional expected skip)
"Define ert `TEST-remote' for remote files."
(declare (indent 1))
`(ert-deftest ,(intern (concat (symbol-name test) "-remote")) ()
,docstring
:tags '(:expensive-test)
:expected-result (or ,expected :passed)
+ (skip-unless (not ,skip))
(let* ((temporary-file-directory
file-notify-test-remote-temporary-file-directory)
(ert-test (ert-get-test ',test)))
@@ -1161,8 +1162,10 @@ delivered."
;; Cleanup.
(file-notify--test-cleanup)))
+;; Unpredictable failures, eg https://hydra.nixos.org/build/86016286
(file-notify--deftest-remote file-notify-test07-many-events
- "Check that events are not dropped for remote directories.")
+ "Check that events are not dropped for remote directories."
+ :passed (getenv "EMACS_HYDRA_CI"))
(ert-deftest file-notify-test08-backup ()
"Check that backup keeps file notification."
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] master dc3f70d: Skip a remote filenotify test on hydra,
Glenn Morris <=