[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] feature/gnus-select2 73c0da2 27/32: Improve search and sel
From: |
Andrew G Cohen |
Subject: |
[Emacs-diffs] feature/gnus-select2 73c0da2 27/32: Improve search and select group creation |
Date: |
Sun, 16 Dec 2018 06:54:05 -0500 (EST) |
branch: feature/gnus-select2
commit 73c0da2b37d7f2caf83a1208de79fa6d0f9d6650
Author: Andrew G Cohen <address@hidden>
Commit: Andrew G Cohen <address@hidden>
Improve search and select group creation
* lisp/gnus/gnus-group.el (gnus-group-make-search-group): Make sure
new group is inserted into the group buffer.
* lisp/gnus/nnselect.el (nnselect-request-create-group): Improve input
of selection function.
---
lisp/gnus/gnus-group.el | 23 ++++++++++++-----------
lisp/gnus/nnselect.el | 2 +-
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index 18ed054..41c0760 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -3209,17 +3209,18 @@ mail messages or news articles in files that have
numeric names."
;; Temporary to make group creation easier
(defun gnus-group-make-search-group (nnir-extra-parms &optional specs)
(interactive "P")
- (let ((name (read-string "Group name: " nil)))
- (gnus-group-make-group
- name
- (list 'nnselect "nnselect")
- nil
- (list
- (cons 'nnselect-specs
- (list
- (cons 'nnselect-function 'nnir-run-query)
- (cons 'nnselect-args
- (nnir-make-specs nnir-extra-parms specs))))))))
+ (let ((name (gnus-read-group "Group name: ")))
+ (with-current-buffer gnus-group-buffer
+ (gnus-group-make-group
+ name
+ (list 'nnselect "nnselect")
+ nil
+ (list
+ (cons 'nnselect-specs
+ (list
+ (cons 'nnselect-function 'nnir-run-query)
+ (cons 'nnselect-args
+ (nnir-make-specs nnir-extra-parms specs)))))))))
(defun gnus-group-read-ephemeral-search-group (nnir-extra-parms
&optional specs)
"Create an nnselect group based on a search. Prompt for a
diff --git a/lisp/gnus/nnselect.el b/lisp/gnus/nnselect.el
index 793775f..132f9dd 100644
--- a/lisp/gnus/nnselect.el
+++ b/lisp/gnus/nnselect.el
@@ -586,7 +586,7 @@ If this variable is nil, or if the provided function
returns nil,
(specs (assq 'nnselect-specs args))
(function-spec
(or (alist-get 'nnselect-function specs)
- (read-from-minibuffer "Function: " nil nil t)))
+ (intern (completing-read "Function: " obarray #'functionp))))
(args-spec
(or (alist-get 'nnselect-args specs)
(read-from-minibuffer "Args: " nil nil t nil "nil")))
- [Emacs-diffs] feature/gnus-select2 7df041f 10/32: Remove unnecessary check gnus-nnselect-group-p, (continued)
- [Emacs-diffs] feature/gnus-select2 7df041f 10/32: Remove unnecessary check gnus-nnselect-group-p, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 c87252e 15/32: New gnus summary sorting functions on rsv, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 514f0cb 04/32: Temporary function to ease search group creation, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 3444486 16/32: Fix pushing marks on nnselect exit, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 fde0e40 21/32: Restore accidentally remove gnus-summary-make-search-group, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 d2e0389 19/32: Improve group-info handling in nnselect, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 6111aa1 09/32: Don't stomp on local variables in gnus-msg, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 c9c16c9 22/32: * lisp/gnus/nnselect.el (nnselect-server-opened): Just return t., Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 2174d0f 20/32: Improve nnselect-request-article, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 8ad88ac 24/32: * lisp/gnus/nnselect.el (nnselect-request-rename-group): Allow it., Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 73c0da2 27/32: Improve search and select group creation,
Andrew G Cohen <=
- [Emacs-diffs] feature/gnus-select2 fe5f3c2 32/32: Set gnus-newsgroup-selection in the summary buffer, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 5868104 30/32: Allow automatic scanning of nnselect groups, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 0693d49 31/32: Remove nnselect-artlist variable in nnselect, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 5699fda 28/32: * lisp/gnus/gnus-srvr.el (gnus-server-mode-map): Use ephemeral group, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 465b580 29/32: * lisp/gnus/nnir.el (nnir-make-specs): Use the current buffer., Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 10c5fa1 18/32: Remove unnecessary listing in nnselect-categorize, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 5d9101a 25/32: Inline nnselect helper macros, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 0187e0b 26/32: Redo entry functions for making search groups, Andrew G Cohen, 2018/12/16
- [Emacs-diffs] feature/gnus-select2 fe97015 01/32: Initial landing of gnus nnselect backend, Andrew G Cohen, 2018/12/16