[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] feature/gnus-select 02b297b 044/218: ; Revert "; Tracing f
From: |
Andrew G Cohen |
Subject: |
[Emacs-diffs] feature/gnus-select 02b297b 044/218: ; Revert "; Tracing for eieio-test random failure (Bug#24503)" |
Date: |
Fri, 14 Dec 2018 03:34:52 -0500 (EST) |
branch: feature/gnus-select
commit 02b297bef0e8edf8a5d8c9021044f777f5a80fec
Author: Noam Postavsky <address@hidden>
Commit: Andrew G Cohen <address@hidden>
; Revert "; Tracing for eieio-test random failure (Bug#24503)"
The tracing seems to prevent the bug from happening.
---
test/Makefile.in | 1 -
test/lisp/emacs-lisp/eieio-tests/eieio-tests.el | 21 +--------------------
2 files changed, 1 insertion(+), 21 deletions(-)
diff --git a/test/Makefile.in b/test/Makefile.in
index 4024d02..42d9880 100644
--- a/test/Makefile.in
+++ b/test/Makefile.in
@@ -152,7 +152,6 @@ endif
WRITE_LOG = > $@ 2>&1 || { STAT=$$?; cat $@; exit $$STAT; }
ifdef EMACS_HYDRA_CI
## On Hydra, always show logs for certain problematic tests.
-lisp/emacs-lisp/eieio-tests/eieio-tests.log \
lisp/net/tramp-tests.log \
: WRITE_LOG = 2>&1 | tee $@
endif
diff --git a/test/lisp/emacs-lisp/eieio-tests/eieio-tests.el
b/test/lisp/emacs-lisp/eieio-tests/eieio-tests.el
index 69dc164..5ba094c 100644
--- a/test/lisp/emacs-lisp/eieio-tests/eieio-tests.el
+++ b/test/lisp/emacs-lisp/eieio-tests/eieio-tests.el
@@ -887,34 +887,15 @@ Subclasses to override slot attributes.")
(should (= (length (eieio-build-class-alist 'opt-test1 nil)) 2))
(should (= (length (eieio-build-class-alist 'opt-test1 t)) 1)))
-(mapatoms (lambda (a)
- (when (and (fboundp a)
- (string-match "\\`cl--?generic"
- (symbol-name a)))
- (trace-function-background a))))
-
(defclass eieio--testing () ())
(defmethod constructor :static ((_x eieio--testing) newname &rest _args)
(list newname 2))
-(defun eieio-test-dump-trace ()
- (message "%s" (with-current-buffer "*trace-output*"
- (goto-char (point-min))
- (while (re-search-forward "[\0-\010\013-\037]" nil t)
- (insert (prog1 (format "\\%03o" (char-before))
- (delete-char -1))))
- (buffer-string))))
-(eieio-test-dump-trace)
-
(ert-deftest eieio-test-37-obsolete-name-in-constructor ()
;; FIXME repeated intermittent failures on hydra and elsewhere (bug#24503).
:tags '(:unstable)
- (with-current-buffer "*trace-output*"
- (erase-buffer))
- (unwind-protect
- (should (equal (eieio--testing "toto") '("toto" 2)))
- (eieio-test-dump-trace)))
+ (should (equal (eieio--testing "toto") '("toto" 2))))
(ert-deftest eieio-autoload ()
"Tests to see whether reftex-auc has been autoloaded"
- [Emacs-diffs] feature/gnus-select 4a6cf41 156/218: * doc/lispref/internals.texi (Writing Emacs Primitives): Fix grammar., (continued)
- [Emacs-diffs] feature/gnus-select 4a6cf41 156/218: * doc/lispref/internals.texi (Writing Emacs Primitives): Fix grammar., Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select b4377a3 164/218: Handle possible classtype values in eieio-persistent-read, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select ff16207 153/218: ; * autogen.sh: Comment., Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 590166c 151/218: Firm up documentation of generalized variables, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select a3e7de9 086/218: Fix mouse-set-point when line numbers are displayed, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 57200d8 084/218: Replace "carriage-return" by "carriage return" in manuals, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 620b63a 092/218: * lisp/progmodes/verilog-mode.el (verilog-mode): Quieten compilation., Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 3ef9943 067/218: * lisp/obsolete/options.el: Remove file., Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 2544299 076/218: Try to stop tramp test hangs on hydra, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 520498d 091/218: Improve port to NetBSD tzalloc, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 02b297b 044/218: ; Revert "; Tracing for eieio-test random failure (Bug#24503)",
Andrew G Cohen <=
- [Emacs-diffs] feature/gnus-select a381e7e 002/218: Define if-let* and derivatives as aliases for if-let etc, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select a8e5163 070/218: Minor changes in mule.texi, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 03e7331 089/218: * lisp/pcomplete.el (pcomplete-here): Move before first reference., Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 040f725 093/218: * lisp/emulation/cua-base.el (cua-paste): Quieten compilation., Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select f5219ae 094/218: Replace some obsolete uses of filter-buffer-substring-functions, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 25950c1 095/218: Suppress warnings about obsolete generics (bug#25556), Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 965f4ec 100/218: * lisp/gnus/gnus-registry.el: Add missing compile-time requirement., Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select e2aebb9 090/218: * test/lisp/ses-tests.el: Quieten compilation., Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select c52e2e2 099/218: Fix 'posn-at-point' when line numbers are displayed, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select e907e4a 102/218: Improve word motion docs (Bug#30815), Andrew G Cohen, 2018/12/14