[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Experimental regexp check: repetition of empty-matching expression
From: |
Paul Eggert |
Subject: |
Re: Experimental regexp check: repetition of empty-matching expression |
Date: |
Fri, 19 Apr 2019 08:24:56 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/13/19 1:09 AM, Mattias Engdegård wrote:
>
> --- a/lisp/mail/mail-extr.el
> +++ b/lisp/mail/mail-extr.el
> @@ -383,7 +383,7 @@ mail-extr-initial-pattern
> ;; Matches telephone extensions.
> (defconst mail-extr-telephone-extension-pattern
> (purecopy
> - "\\(\\([Ee]xt\\|\\|[Tt]ph\\|[Tt]el\\|[Xx]\\).?\\)? *\\+?[0-9][- 0-9]+"))
> + "\\(\\([Ee]xt\\|[Tt]ph\\|[Tt]el\\|[Xx]\\).?\\)? *\\+?[0-9][- 0-9]+"))
> ^
> Doesn't it look like the dot is meant to be escaped?
Yes, and I installed the attached patch to fix that. Thanks.
>
> --- a/lisp/net/tramp-adb.el
> +++ b/lisp/net/tramp-adb.el
> @@ -53,7 +53,7 @@ tramp-adb-method
> "When this method name is used, forward all calls to Android Debug
> Bridge.")
>
> (defcustom tramp-adb-prompt
> -
> "^\\(?:[[:digit:]]*|?\\)?\\(?:[[:alnum:]\e;address@hidden:alnum:]]*[^#\\$]*\\)?[#\\$][[:space:]]"
> +
> "^[[:digit:]]*|?\\(?:[[:alnum:]\e;address@hidden:alnum:]]*[^#\\$]*\\)?[#\\$][[:space:]]"
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
> There is a second one a bit later in the same regexp.
>
Michael already fixed this.
0001-Fix-mail-extr-regexp-typo-with.patch
Description: Text Data