[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> fram
From: |
Robert Pluim |
Subject: |
Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change |
Date: |
Wed, 17 Apr 2019 10:24:47 +0200 |
>>>>> On Tue, 16 Apr 2019 11:18:21 -0600, Alex Gramiak <address@hidden> said:
Alex> Robert Pluim <address@hidden> writes:
>> CC xdisp.o xdisp.c:29300:37: error: no member named
>> 'x_highlight_frame' in 'struct ns_display_info'; did you mean
>> 'ns_highlight_frame'? || f != FRAME_DISPLAY_INFO
>> (f)->x_highlight_frame) ^~~~~~~~~~~~~~~~~ ns_highlight_frame
>> ./nsterm.h:884:17: note: 'ns_highlight_frame' declared here
>> struct frame *ns_highlight_frame; ^ 1 error generated.
>>
>> (on macOS)
Alex> Ah, I originally renamed the x_highlight_frame on W32/NS to
Alex> {w32,ns}_*, but decided against it since xdisp.c used the
Alex> attribute directly (a hook or union interface could be added
Alex> later). Perhaps it should be renamed native_highlight_frame
Alex> until then, though.
Alex> I pushed the fix, do you get any other errors/warnings on
Alex> macOS?
nsterm.m:2400:1: error: conflicting types for 'ns_query_color'
ns_query_color(void *col, XColor *color_def, bool setPixel)
^
./nsterm.h:1146:1: note: previous declaration is here
ns_query_color (void *col, XColor *color_def, int setPixel);
^
CC nsfns.o
nsfns.m:1389:4: warning: implicit declaration of function 'x_make_frame_visible'
is invalid in C99 [-Wimplicit-function-declaration]
x_make_frame_visible (f);
CC nsimage.o
nsimage.m:196:11: warning: implicit declaration of function 'x_find_image_file'
is invalid in C99 [-Wimplicit-function-declaration]
found = x_find_image_file (file);
^
nsimage.m:196:9: warning: incompatible integer to pointer conversion assigning
to 'Lisp_Object' (aka 'union Lisp_X *') from 'int' [-Wint-conversion]
found = x_find_image_file (file);
Robert
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Robert Pluim, 2019/04/16
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Alex Gramiak, 2019/04/16
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Eli Zaretskii, 2019/04/16
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change,
Robert Pluim <=
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Alex Gramiak, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Robert Pluim, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Alex Gramiak, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Robert Pluim, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Robert Pluim, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Alex Gramiak, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Robert Pluim, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Alex Gramiak, 2019/04/18