[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master e9e807e: Don't remove notify descriptor that is already gone
From: |
Michael Albinus |
Subject: |
Re: master e9e807e: Don't remove notify descriptor that is already gone |
Date: |
Tue, 16 Apr 2019 09:04:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Unknown <address@hidden> writes:
Hi Mattias,
> Don't remove notify descriptor that is already gone
>
> * lisp/autorevert.el (auto-revert-use-notify, auto-revert-mode,
> global-auto-revert-mode, auto-revert-notify-rm-watch,
> auto-revert-notify-add-watch, auto-revert-notify-handler,
> auto-revert-notify-rm-watch-callback):
> Don't remove a notify descriptor after receiving a `stopped' notification
> event, because the descriptor is then already gone and any attempt to
> remove it causes a recursive call to `auto-revert-notify-handler'.
Thanks for this!
I haven't tested thoroughly yet, but wouldn't it suffice if in
auto-revert-notify-rm-watch there is just the test
(when (file-notify-valid-p auto-revert-notify-watch-descriptor)
instead of
(when auto-revert-notify-watch-descriptor
Best regards, Michael.
- Re: master e9e807e: Don't remove notify descriptor that is already gone,
Michael Albinus <=