[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [elpa] master 1a6a4a3: Search further if d-g-cur-status is nil (Bug#
From: |
Michael Albinus |
Subject: |
Re: [elpa] master 1a6a4a3: Search further if d-g-cur-status is nil (Bug#35121) |
Date: |
Thu, 04 Apr 2019 09:08:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
address@hidden (Noam Postavsky)
writes:
Hi Noam,
> --- a/packages/debbugs/debbugs-gnu.el
> +++ b/packages/debbugs/debbugs-gnu.el
> @@ -1592,7 +1592,9 @@ removed instead."
> current-prefix-arg
> (when (derived-mode-p 'message-mode)
> (current-buffer)))))
> - (let* ((status (debbugs-gnu-current-status))
> + (let* ((status (or (debbugs-gnu-current-status)
> + (gethash bugid debbugs-cache-data)
> + (debbugs-get-status bugid)))
> (version
> (if (and
> (member message '("close" "done"
Yesterday evening I was a little bit tired, so I didn't check precisely.
`debbugs-get-status' consults the cache first, so there is no reason to
call `gethash' explicitly. Furthermore, `debbugs-get-status' checks
whether cache entries have been expired, and refuses them.
That's why `gethash' isn't called anywhere else in debbugs-gnu.el; it is
an implementation detail of debbugs.el we shouldn't care.
Best regards, Michael.
- Re: [elpa] master 1a6a4a3: Search further if d-g-cur-status is nil (Bug#35121),
Michael Albinus <=