[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: TRAMP VC optimization fails: non-TRAMP filenames handled incorrectly
From: |
Michael Albinus |
Subject: |
Re: TRAMP VC optimization fails: non-TRAMP filenames handled incorrectly in async operations. |
Date: |
Tue, 02 Apr 2019 15:18:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Daniel Pittman <address@hidden> writes:
Hi Daniel,
> Yes. Tramp fights indeed with timers, and so I have disabled
> timers in tramp-accept-process-output already. Maybe we shall do
> the same in tramp-send-string? Would the following patch help?
>
> In brief testing – 100 percent reproducible error, but only one
> instance – this patch did fix the problem.
Thanks for testing! I've pushed the patch, slightly extended, to the
repositories.
> I haven't tried to provoke a non-local exit from anything contained
> within, or anything like that, since you obviously omitted the code
> for that in this test patch.
Good catch. I've wrapped process-send-string by with-local-quit, as I
did already with accept-process-output. The other errors shall be
handled by the Tramp machinery.
> So, yeah, I think that is sufficient.
Please continue to stress Tramp, and report problems. Much appreciated!
Best regards, Michael.