[debbugs-tracker] bug#34592: closed ([PATCH] gnu: python-fenics-dijitso: Fix build.)

[GNU bug Tracking System]

Your message dated Wed, 20 Feb 2019 21:40:08 +0100
with message-id <address@hidden>
and subject line Re: [bug#34592] [PATCH] gnu: python-fenics-dijitso: Fix build.
has caused the debbugs.gnu.org bug report #34592,
regarding [PATCH] gnu: python-fenics-dijitso: Fix build.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
34592: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34592
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: python-fenics-dijitso: Fix build.
>
>
>
>
> Date: 
>
> Wed, 20 Feb 2019 12:16:07 +0000
>
>
>
>
> * gnu/packages/simulation.scm (python-fenics-dijitso)[arguments]: Skip
> parallel tests.
> ---
>  gnu/packages/simulation.scm | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm
> index 20b62f3..3637cc3 100644
> --- a/gnu/packages/simulation.scm
> +++ b/gnu/packages/simulation.scm
> @@ -268,6 +268,11 @@ problems for efficient solution on parallel systems.")
>               (setenv "PYTHONPATH"
>                       (string-append (getcwd) ":" (getenv "PYTHONPATH")))
>               (with-directory-excursion "test"
> +               ;; Disable parallel tests to avoid race condition.  See
> +               ;; https://github.com/pytest-dev/pytest-cov/issues/237.
> +               (substitute* "runtests.sh"
> +                 (("for p in 1 4 8 16; do")
> +                  "for p in 1; do"))
>                 (invoke "./runtests.sh"))
>               #t)))))
>      (home-page "https://bitbucket.org/fenics-project/dijitso/";)
> -- 
> 1.8.3.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#34592] [PATCH] gnu: python-fenics-dijitso: Fix build.
>
>
>
>
> Date: 
>
> Wed, 20 Feb 2019 21:40:08 +0100
>
>
>
>
> User-agent: 
>
> mu4e 1.0; emacs 26.1
>
>
>
>
> Paul Garlick <address@hidden> writes:
>
> > * gnu/packages/simulation.scm (python-fenics-dijitso)[arguments]: Skip
> > parallel tests.
> > ---
> >  gnu/packages/simulation.scm | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm
> > index 20b62f3..3637cc3 100644
> > --- a/gnu/packages/simulation.scm
> > +++ b/gnu/packages/simulation.scm
> > @@ -268,6 +268,11 @@ problems for efficient solution on parallel systems.")
> >               (setenv "PYTHONPATH"
> >                       (string-append (getcwd) ":" (getenv "PYTHONPATH")))
> >               (with-directory-excursion "test"
> > +               ;; Disable parallel tests to avoid race condition.  See
> > +               ;; https://github.com/pytest-dev/pytest-cov/issues/237.
> > +               (substitute* "runtests.sh"
> > +                 (("for p in 1 4 8 16; do")
> > +                  "for p in 1; do"))
> >                 (invoke "./runtests.sh"))
> >               #t)))))
> >      (home-page "https://bitbucket.org/fenics-project/dijitso/";)
>
> I wondered if we could use the #:parallel-tests? argument instead, but
> the python-build-system does not support it.  This approach looks fine
> to me.
>
> Thanks!
>
> I pushed it to the master branch with commit 7a82074ca6.
>
> --
> Ricardo
>
>
>
> --- End Message ---