Re: [Pnet-developers] [patch #5514] Fix HAVE_TM_GM TOFF logic for ILGetTimeZoneAdjust

[ktreichel]

Hi Roman,

thanks for the patch.

But with this change the Win32 support will never be included.

Maybe it's better do remove only the #ifdef ... #endif around the declaration 
of timezone ?

Can you check if this fixes your issue too ?

Cheers,

Klaus

> -----Ursprüngliche Nachricht-----
> Von: Roman I Khimov <address@hidden>
> Gesendet: 01.11.06 18:05:24
> An:  address@hidden
> Betreff: [Pnet-developers] [patch #5514] Fix HAVE_TM_GMTOFF logic for 
> ILGetTimeZoneAdjust


> 
> URL:
>   <http://savannah.gnu.org/patch/?5514>
> 
>                  Summary: Fix HAVE_TM_GMTOFF logic for ILGetTimeZoneAdjust
>                  Project: DotGNU Portable.NET
>             Submitted by: roman_khimov
>             Submitted on: СреЎа 01.11.2006 at 17:05
>                 Category: None
>                 Priority: 3 - Low
>                   Status: None
>                  Privacy: Public
>              Assigned to: None
>         Originator Email: 
>              Open/Closed: Open
> 
>     _______________________________________________________
> 
> Details:
> 
> Cross-compiling pnet for ARM device with newlib C library I've got this
> error:
> 
> time.c: In function â€&#65533;ILGetTimeZoneAdjustâ€&#65533;:
> time.c:242: error: â€&#65533;timezoneâ€&#65533; undeclared (first use in this 
> function)
> time.c:242: error: (Each undeclared identifier is reported only once
> time.c:242: error: for each function it appears in.)
> time.c:247: warning: control reaches end of non-void function
> make: *** [time.o] Ð&#65533;Ñ&#65533;Обка 1
> 
> Looks like HAVE_TM_GMTOFF logic is broken here, because if it's not defined
> it can't be returned from function.
> 
> So I've cooked up this patch that resolves this issue, hope it's valid for
> inclusion.
> 
> 
> 
> 
> 
>     _______________________________________________________
> 
> File Attachments:
> 
> 
> -------------------------------------------------------
> Date: СреЎа 01.11.2006 at 17:05  Name:
> fix_HAVE_TM_GMTOFF_logic_for_ILGetTimeZoneAdjust.patch  Size: 775B   By:
> roman_khimov
> Patch to fix HAVE_TM_GMTOFF logic in ILGetTimeZoneAdjust function
> <http://savannah.gnu.org/patch/download.php?file_id=11133>
> 
>     _______________________________________________________
> 
> Reply to this item at:
> 
>   <http://savannah.gnu.org/patch/?5514>
> 
> _______________________________________________
>   Message sent via/by Savannah
>   http://savannah.gnu.org/
> 
> _______________________________________________
> Pnet-developers mailing list
> address@hidden
> http://dotgnu.org/mailman/listinfo/pnet-developers


__________________________________________________________________________
Erweitern Sie FreeMail zu einem noch leistungsstärkeren E-Mail-Postfach!        
        
Mehr Infos unter http://freemail.web.de/home/landingpad/?mc=021131