dotgnu-pnet
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Pnet-developers] Re: [DotGNU] How to submit a patch for multiple bu


From: Carl-Adam Brengesjo
Subject: Re: [Pnet-developers] Re: [DotGNU] How to submit a patch for multiple bugs ?
Date: Mon, 10 Jan 2005 17:06:44 +0100
User-agent: Mozilla Thunderbird 1.0 (X11/20041209)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Marc Haisenko wrote:
| On Monday 10 January 2005 13:27, Marc Haisenko wrote:
|
|>Hi folks,
|>I'd like to submit one patch that fixes two or three bugs at once. For one
|>bug there already is a bug report. How should I submit the patch ?
Should I
|>file two additional bug reports and then submit the patch to the patch
|>tracker with the note that it fixes bugs #123, #124 and #125 (for example)
|>? Or should I try to split it into three patches and attach those three to
|>the bug reports ?
|>C'ya,
|>   Marc
|
|
| I should add that it would be hard to split the patch into three
parts, as
| I've split a function to fix one bug and the fix for another bug is also
| doing stuff in that function... I would have to do it in such a way
that one
| would have to apply these patches in a specific order.
|

If there's a report of only one bug, then I don't see the need to report
another bug. If we were to do that, and a bug in the core of, say, SWF,
caused a problem showing up in 100 different places, we'd be flooded
with bug reports. And having different polycies for different bug cases
is just a weird policy :)

Just stating that your patch fixed the reported bug, e.g., "this patch
fixes a problem where the return value is null, causing, for example,
FooBar to throw an exception (bug #12345)".

That's more than enough, IMHO.


Regards, Carl-Adam Brengesjö.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFB4qgTgLIl8/jW7bMRAh3+AJ4vckeDgai6MhpmQSMgf6lGnxxa6wCdE0dn
PEP3T3Z2jYp8NtwEjSYj3nA=
=pMuJ
-----END PGP SIGNATURE-----


reply via email to

[Prev in Thread] Current Thread [Next in Thread]