dotgnu-general
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [DotGNU]NEWBIE TODO: Fix MemoryStream class


From: Thong \(Tum\) Nguyen
Subject: RE: [DotGNU]NEWBIE TODO: Fix MemoryStream class
Date: Mon, 12 May 2003 21:04:26 +1200

Whoops sorry.  I forgot to change those back.  I was testing with
MS.NET...

^Tum


> -----Original Message-----
> From: Gopal V [mailto:address@hidden
> Sent: Monday, 12 May 2003 8:51 p.m.
> To: Thong (Tum) Nguyen
> Cc: 'DotGNU Mailing List'
> Subject: Re: [DotGNU]NEWBIE TODO: Fix MemoryStream class
> 
> If memory serves me right, Thong (Tum) Nguyen wrote:
> > Patch has been sent :-).
> 
> Cool ....
> 
> > thereafter (meaning you should get only ~ O(log2(n/1024)) array
> > reallocations...or something like that ;)).
> 
> Ok ...
> 
> Btw, your patch had some small unecessary (or incorrect) changes..
> 
>                       if (streamclosed)
> !                             throw new ObjectDisposedException(null,
> _("IO_StreamClosed"));
>                       return topLimit - bottomLimit;
>               }
>       }
> --- 408,414 ----
>               get
>               {
>                       if (streamclosed)
> !                             throw new ObjectDisposedException(null,
> ("IO_StreamClosed"));
> 
> The _() should be retained ... it's the locale based lookup
routines...
> 
> Committed ... any test cases anyone ?
> 
> Gopal
> --
> The difference between insanity and genius is measured by success
> _______________________________________________
> Developers mailing list
> address@hidden
> http://dotgnu.org/mailman/listinfo/developers



reply via email to

[Prev in Thread] Current Thread [Next in Thread]