Dolibarr ERP & CRM » Tasks and Feature requests » task #645 Remove field fk_product_fournisseur_price from all "->addline" and "->updateline" method. Remove fields from details tables.Dernières modifications
Répondre
État| Détails |
| Submitted on: | 19/12/2012 15:57 | | Submitted by: | Laurent Destailleur (eldy) |
| Last Modified On: | 06/06/2013 19:47 | |
| Summary: | Remove field fk_product_fournisseur_price from all "->addline" and "->updateline" method. Remove fields from details tables. |
| Description: | Remove field fk_product_fournisseur_price from all addline method and details tables.
This field is useless, because the pa_ht is used instead for margin calculation. |
| Priority: | 9 - Highest | | Open to Any Developer: | No |
| Subproject: | Aucun | | Assigned to (multiple): | Aucun |
| Etat |
| Start Date: | - | | End Date: | - |
| Completion (0-100%): | 0 | | Status: | Closed |
Commentaires- Andriolo Hubert 29/08/2013 18:27
- I just add another comment on this :
I have many orders not invoiced, all invoices are delivered orders, I don't base my statistics on orders, but on invoices.
When fk_product_fournisseur_price disappeared, it became a nightmare for me to track (in phpmyadmin)
what i have bought to which supplier, at which price, and when...
If my customer, for example wants to know where I have bought the product and when (let's say my product is disinfectant and smells strangely... he has a problem!)...
fk_product-fourn_price would let me know to which supplier I bought it...
And sorting by dates of supplier (and stock left) I could know at whih period,
and find the delivery receipt of my supplier to tell him what is the "lot number" of the product
and alert authorities about the problem on this "lot"
Now the it disappeared is there another way to trace-ability ? - Christophe Battarel 06/06/2013 19:47
- just remember that since we don't have any margin field (amount or rate) anywhere in the database, the margin is calculated from the pa_ht stored in the facturedet table, so it is not useless at all.
- Laurent Destailleur 06/06/2013 18:53
- I agree with you. What i would like to say is that field is useless once invoice is done.
If we speak about order, proposal, this field is required to be used later to get current supplier price (or not) when building invoice.
For invoice, field should be useless. However to have same fields between elements (orders, invoices, proposal...), we may keep the field also for invoices. So i close task (i have just added comment onto fields of sql files) - Laurent Destailleur 06/06/2013 18:53
- I agree with you. What i would like to say is that field is useless once invoice is done.
If we speak about order, proposal, this field is required to be used later to get current supplier price (or not) when building invoice.
For invoice, field should be useless. However to have same fields between elements (orders, invoices, proposal...), we may keep the field also for invoices. So i close task (i have just added comment onto fields of sql files) - Christophe Battarel 06/06/2013 14:21
- i persist to think that margin calculation must be made at invoice time, so the buying price must be the one at invoice time.
if a customer orders a 10 euros product that costs me 5 euros at this time, but when i do the invoice it costs 6 euros, the margin is 10 - 6, and not 10 - 5.
other solution, we should maybe use an average price (PMP in french) but it can only be done with stocked products. - Laurent Destailleur 05/06/2013 22:34
- Price used when order is defined must be saved into pa_ht.
So price can change after, it is not a problem since value used was saved during order creation. There is no reason to have a link to a table that is a view at t time, so a value useless for calculation since what we need is value when element was created. - address@hidden 19/12/2012 22:34
- This field is used in case supplier price change between order and invoice
- Laurent Destailleur 19/12/2012 17:42
- Remove field fk_product_fournisseur_price from all "->addline" and "->updateline" method.
Remove fields from details tables.
Remove also field label that are duplicate fields and create conflicts.
|
|
I have many orders not invoiced, all invoices are delivered orders, I don't base my statistics on orders, but on invoices.
When fk_product_fournisseur_price disappeared, it became a nightmare for me to track (in phpmyadmin)
what i have bought to which supplier, at which price, and when...
If my customer, for example wants to know where I have bought the product and when (let's say my product is disinfectant and smells strangely... he has a problem!)...
fk_product-fourn_price would let me know to which supplier I bought it...
And sorting by dates of supplier (and stock left) I could know at whih period,
and find the delivery receipt of my supplier to tell him what is the "lot number" of the product
and alert authorities about the problem on this "lot"
Now the it disappeared is there another way to trace-ability ?