Re: qa_fir_filter test fails in make test

[Marcus Müller]

Hi Ali,

this is due to Clayton fixing a VOLK bug: the current GNU Radio test is buggy and expects 
wrong results. Fixing the VOLK bug made the test fail:

https://github.com/gnuradio/gnuradio/pull/6980

So, don't worry: although it doesn't look like it, this test failing is a good thing :) 
And: He also already fixed the bug in GNU Radio, and Jeff backported the fix to the 
maint-3.10 line, so that GNU Radio 3.10.9.0 will contain a fixed test.

Best regards,
Marcus Müller


On 16.12.23 13:27, Ali G. Dezfuli wrote:
> Hi all,
> I am installing gnuradio v3.10.8.0
> Both UHD and Volk have passed their tests in make test completely (100%)
> but as I run make test after building gnuradio v3.10.8.0 I get this single
> error:
>
>
> 139/263 Testing: qa_fir_filter
> 139/263 Test: qa_fir_filter
> Command: "/usr/bin/sh" "qa_fir_filter_test.sh"
> Directory: /home/ali/opt/gnuradio/build/gr-filter/python/filter
> "qa_fir_filter" start time: Dec 16 15:35 +0330
> Output:
> ----------------------------------------------------------
> .......FF..
> ======================================================================
> FAIL: test_fir_filter_fsf_001 (__main__.test_filter)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>    File "/home/ali/opt/gnuradio/gr-filter/python/filter/qa_fir_filter.py",
> line 173, in test_fir_filter_fsf_001
>      self.assertComplexTuplesAlmostEqual(expected_data, result_data, 5)
>    File
> "/home/ali/opt/gnuradio/gnuradio-runtime/python/gnuradio/gr_unittest.py",
> line 73, in assertComplexTuplesAlmostEqual
>      return all([
>    File
> "/home/ali/opt/gnuradio/gnuradio-runtime/python/gnuradio/gr_unittest.py",
> line 74, in <listcomp>
>      self.assertComplexAlmostEqual(x, y, places, msg)
>    File
> "/home/ali/opt/gnuradio/gnuradio-runtime/python/gnuradio/gr_unittest.py",
> line 37, in assertComplexAlmostEqual
>      raise self.failureException(
> AssertionError: 1 != 2 within 5 places
>
> ======================================================================
> FAIL: test_fir_filter_fsf_002 (__main__.test_filter)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>    File "/home/ali/opt/gnuradio/gr-filter/python/filter/qa_fir_filter.py",
> line 188, in test_fir_filter_fsf_002
>      self.assertComplexTuplesAlmostEqual(expected_data, result_data, 5)
>    File
> "/home/ali/opt/gnuradio/gnuradio-runtime/python/gnuradio/gr_unittest.py",
> line 73, in assertComplexTuplesAlmostEqual
>      return all([
>    File
> "/home/ali/opt/gnuradio/gnuradio-runtime/python/gnuradio/gr_unittest.py",
> line 74, in <listcomp>
>      self.assertComplexAlmostEqual(x, y, places, msg)
>    File
> "/home/ali/opt/gnuradio/gnuradio-runtime/python/gnuradio/gr_unittest.py",
> line 37, in assertComplexAlmostEqual
>      raise self.failureException(
> AssertionError: 5 != 6 within 5 places
>
> ----------------------------------------------------------------------
> Ran 11 tests in 0.028s
>
> FAILED (failures=2)
> <end of output>
> Test time =   0.12 sec
> ----------------------------------------------------------
> Test Failed.
> "qa_fir_filter" end time: Dec 16 15:35 +0330
> "qa_fir_filter" time elapsed: 00:00:00
> ----------------------------------------------------------
>
>
> I am using Ubuntu 22.04.3.
> On a core i9 13900K
>
> p.s. I changed the branch to 3.10.7.0 and v3.10.6.0 but the error remains
> the same
>
> Thanks!