|
From: | Achilleas Anastasopoulos |
Subject: | Re: [Discuss-gnuradio] how do I submit updates? |
Date: | Tue, 22 Feb 2011 11:43:36 -0500 |
User-agent: | Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 |
Tom, sounds great. BTW, the correct address is https://github.com/anastas/gnuradio_turbo Also, there was a related email I sent earlier regarding .gitignore and automatically generated files. I would really like to get your feedback on this because I am not sure I understand all the intricacies of git... I reattach the question below. thanks Achilleas ============= I am looking at the file Makefile.gen inside gr-trellis/src/lib which says that is automatically generated. This is indeed true since when i delete it and make gr-trellis it correctly generates it with all additions, etc that are implied by the file generate_trellis.py However if I delete it and try to do ./bootstrap (on the whole project) then automake reports an error automake: cannot open < gr-trellis/src/lib/Makefile.gen: No such file or directory I came across this issue when i decided to put Makefile.gen in the .gitignore and not track it since it is machine generated... What is the explanation of this behavior? Shouldn't all automatically generated files not be tracked by git? thanks Achilleas ============== On 2/22/2011 10:54 AM, Tom Rondeau wrote:
On Tue, Feb 22, 2011 at 12:18 AM, Achilleas Anastasopoulos <address@hidden> wrote:I had some time and finished updating gr-trellis with serial/parallel encoders and decoders. I also refactored all heavy-duty algorithms ()such as viterbi, siso, turbo, etc) and used templates for simplicity. I have these updates on branch "turbo" on my github site: https://github.com/anastas/gnuradio_turbo.git What is the process for submitting those for merging with master? thanks AchilleasYou are about 90% of the way there. I'll take it from here, check over the code, and merge it in. Thanks! Tom
[Prev in Thread] | Current Thread | [Next in Thread] |