Re: [Chicken-hackers] [PATCH] Avoid dropping -emit-types-file and -emit-inline-file when compiling statically

[felix . winkelmann]

> Hi all,
>
> I found out about this issue yesterday while porting sql-de-lite:
> https://bugs.call-cc.org/ticket/1550
>
> I noticed that the egg compilation code specifically drops the
> options -emit-types-file and -emit-inline-file for performance
> reasons.  It doesn't look like that has such a huge impact on
> performance (at least for small files), and it breaks compilation
> of components which depend on another component's types file or
> inline file.  So it looks like a case of premature optimization :)
>
> The patch is very straightforward: it simply removes the offending
> code that drops these options.

I'm not sure this is right. You simply disable this without really
addressing the problem. The types-file should remain, removing
it externally (by "hg clean" or whatever) breaks the dependency
chain. I don't yet know what the proper solution is, but simply dropping
it doesn't look right to me (this piece of code was not done for
performance reasons, btw, but to avoid changing timestamps).


felix