Re: [certi-dev] Various fix to the HLA1516e implementation

[Eric Noulard]

Thank Jean-Philippe;

I'll try to handle hash without requiring C++11 (even if we may come to that in the future for various reason).

Would you be able to try the attached patch in your environment please?

2015-02-24 15:14 GMT+01:00 Jean-Philippe Lebel <address@hidden>:

Attached are the patch file in the correct format

JPL

On 2/23/2015 9:06 AM, Eric Noulard wrote:

Hi Jean-Philippe,

Jean-Loup and I will have a look at the content of those this afternoon.

The "commit" seems right but you seemed to have generated the patch using git diff instead of git format-patch.

The "format-patch" command is better because it produces numbered patch files which

1) may be used with git apply

2) convey meta-informations (like Author Name)

Go to your git tree and try:

git format-patch 3924a46b2aa6c5b55c99743ccd604e93a538ac02

or any other commit references and you'll see which set of file is generated.

Then send those file again please.

Thank you for your contribution, we will keep you posted w.r.t. master merge.

2015-02-20 22:14 GMT+01:00 Jean-Philippe Lebel <address@hidden>:

Hi Guys,

I did four commits to GIT. I hope I did it right. Just in case, here is a list of the commit I've done

Commit:b0d0783d0be7d4964e1f4df66b8bddbbff677397
* added implementation to the HASH function for the HLA1516e handles

Commit:70cfb1494575f855e458c43ec8f293c0c93de615
* Added parsing code to allow reading of HLA 1516e XML-FOM Files

Commit:17fabc11eda8605ce12b8b772e537fe8330b8c95
* change the conversion for wstring to string in exception handling. Passing directly from stringstream to a const_iterator is unreliable in some cases (VS2010 at least). Added a temp variable to ensure the iterators are valid.

Commit:3924a46b2aa6c5b55c99743ccd604e93a538ac02
* added a couple of validation to the VariableLengthData data structure to prevent crash when copiing an empty VariableLengthData to another VariableLengthData (crash found when adding an item of a map values)

I've attached the corresponding patches.

Please confirm if the commit were done correctly and if so, if the changes will be merged to the master branch.

THanks, merci

(Réponse en français ou anglais, à votre guise)


--
Jean-Philippe Lebel, ing., MBA
ForwardSim inc.
Tel.: 418-650-3493 ext 6001
Fax.: 418-650-5661


--
CERTI-Devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/certi-devel

--

Eric
L'élection n'est pas la démocratie -- http://www.le-message.org

-- 
Jean-Philippe Lebel, ing., MBA
ForwardSim inc.
Tel.: 418-650-3493 ext 6001
Fax.: 418-650-5661

--
CERTI-Devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/certi-devel

--

Eric
L'élection n'est pas la démocratie -- http://www.le-message.org

0001-Implement-Handle-hash-method-using-MurmurHash2.patch
Description: Text Data