wget claims "Success" when it failed to write to local directory

[Christian Rosentreter]

Hi there,

There's a minor cosmetic bug in wget 1.x where it claims "Success" when it in 
fact entirely failed to write to the local
disk, e.g. because of missing permissions/ write access to the current 
directory. The return code is "3" however, so it's
basically only the message that it prints on screen that is funny in a 
suspicious way:


### Prepare situation…
$ mkdir foobar
$ chmod -w foobar   # remove write access
$ cd foobar


### Note: the "Permission denied" and "Cannot write to" messages, but we
###       get a "(Success)" anyway:
$ wget https://www.christianrosentreter.com/
--2023-10-21 17:05:35--  https://www.christianrosentreter.com/
Resolving www.christianrosentreter.com (www.christianrosentreter.com)... 
85.13.142.16
Connecting to www.christianrosentreter.com 
(www.christianrosentreter.com)|85.13.142.16|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
index.html: Permission denied

Cannot write to 'index.html' (Success).


### The return code seems to be reasonable though:
$ echo $?
3


### Version tested:
$ wget --version
GNU Wget 1.21.4 built on darwin14.5.0.

+cares +digest -gpgme +https +ipv6 +iri +large-file +metalink -nls 
+ntlm +opie +psl +ssl/openssl

…cut…