bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH v3] bug #45790: wget prints it's progress even whe


From: Wajda, Piotr
Subject: Re: [Bug-wget] [PATCH v3] bug #45790: wget prints it's progress even when background
Date: Wed, 19 Oct 2016 11:57:06 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.4.0


Sorry, I had the impression there was some discussion going on !?

My only confusion was that during testing on windows, when sending CTRL+C or CTRL+Break it immediately terminates, which is basically what I think it should do for CTRL+C. Not sure about CTRL+Break. But the same behaviour was with current wget version (without my patches), so I think it's correct.

But apart from that:
- please add a space after if statements.
- please add a space between function name and (.
- please make local commits with appropriate commit messages (see git log for
examples), generate your patches with 'git format-patch -3' (-3 for your last
3 commits) and send them as attachments.

Corrected and sent.

Thanks
Piotr



reply via email to

[Prev in Thread] Current Thread [Next in Thread]