bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-wget] [PATCH 06/25] Add file size computation in Metalink module


From: Matthew White
Subject: [Bug-wget] [PATCH 06/25] Add file size computation in Metalink module
Date: Sat, 10 Sep 2016 12:48:53 +0200

[Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok]

[The contrib/check-hard warnings are at the bottom]

This adds the file size computation feature to the Metalink module.

The following description is verbatim from the patch:
-----
Reject downloaded files when they do not agree with their Metalink/XML
metalink:size: https://tools.ietf.org/html/rfc5854#section-4.2.14

At the moment of writing, Metalink/HTTP headers do not provide a file
size field. This information could be obtained from the Content-Length
header field: https://tools.ietf.org/html/rfc6249#section-7
-----

In file included from metalink.c:30:0:
metalink.c: In function 'retrieve_from_metalink':
metalink.c:265:28: warning: ISO C90 does not support the 'll' gnu_printf length 
modifier [-Wformat=]
                   DEBUGP (("Declared size: %lld\n", mfile->size));
                            ^
wget.h:130:54: note: in definition of macro 'DEBUGP'
 #define DEBUGP(args) do { IF_DEBUG { debug_logprintf args; } } while (0)
                                                      ^
metalink.c:266:59: warning: ISO C90 does not support 'long long' [-Wlong-long]
                   DEBUGP (("Computed size: %lld\n", (long long) 
local_file_size));
                                                           ^
wget.h:130:54: note: in definition of macro 'DEBUGP'
 #define DEBUGP(args) do { IF_DEBUG { debug_logprintf args; } } while (0)
                                                      ^
metalink.c:266:28: warning: ISO C90 does not support the 'll' gnu_printf length 
modifier [-Wformat=]
                   DEBUGP (("Computed size: %lld\n", (long long) 
local_file_size));
                            ^
wget.h:130:54: note: in definition of macro 'DEBUGP'
 #define DEBUGP(args) do { IF_DEBUG { debug_logprintf args; } } while (0)       
                                               ^

Regards,
Matthew

-- 
Matthew White <address@hidden>

Attachment: 0006-Add-file-size-computation-in-Metalink-module.patch
Description: Text Data

Attachment: pgpscguteUMK1.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]