Re: Patches against sh-utils 2.0.11

[Jim Meyering]

Hi Peter,

Thanks for the patches!

"H. Peter Anvin" <address@hidden> wrote:
> Here are two small patches against sh-utils 2.0.11.  They do:
>
> a) Enable compiling with gcc 2.91.66/glibc 2.1.3 (RedHat Linux 6.1); this
> is the __restrict_arr patch.

Why is that necessary?
Please keep the Cc: address@hidden
If it needs to be changed, it will be changed in glibc first.

> b) The following small changes for "date -R":
>
>    i) Remove space-padding the date field, per the recommendation in RFC
> 2822, section 3.3.  Other than that, "date -R" should already be RFC 2822
> compliant without using "obsolete" features.
>
>    ii) Change LC_TIME instead of LC_ALL.  LC_ALL is overkill, and would
> have unwanted side effects if there is an error message.

Thanks!  I've applied that patch.

> I was considering adding --rfc-2822 as an option (alias for --rfc-822),
> but it would have the unwanted result that --rfc would now be ambiguous.
>
>       -hpadiff -ur orig/sh-utils-2.0.11/lib/regex.h 
> sh-utils-2.0.11/lib/regex.h
> --- orig/sh-utils-2.0.11/lib/regex.h  Sun Oct 29 05:13:04 2000
> +++ sh-utils-2.0.11/lib/regex.h       Thu Jul 19 11:57:49 2001
> @@ -523,9 +523,12 @@
>  #   define __restrict
>  #  endif
>  # endif
> +#endif
> +
>  /* For now unconditionally define __restrict_arr to expand to nothing.
>     Ideally we would have a test for the compiler which allows defining
>     it to restrict.  */
> +#ifndef __restrict_arr
>  # define __restrict_arr
>  #endif
>  

...