bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-inetutils] On the variable attribute "extern".


From: Mats Erik Andersson
Subject: [bug-inetutils] On the variable attribute "extern".
Date: Wed, 8 Sep 2010 21:31:42 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

Hello,

when looking at the code in "src/tftp.c" I observe six variables
that are declared as "extern", yet later all six variables are
instantiated in ordinary declarations.

The only obvious linking of "src/tftp.o" is done against
"libinetutils/tftpsubs.o", where the indicated six variables
are not imported at all.

Is there some other less obvious library code that could make
use of these values? Debugging code? Is the use of "extern"
a remnant from earlier stages of development, or is there
some policy stating that some visual markers are desirable?

Although harmless, all six instances do not belong in "src/tftp.c",
so I would remove them unless I hear good reasons for the opposite!


Best regards,
Mats E A



reply via email to

[Prev in Thread] Current Thread [Next in Thread]