Re: [bug-inetutils] IPv6 support for inetd, telnet and telnetd

[Göran Weinholt]

On Mon, Apr 19, 2004 at 04:36:31PM +0200, Jeroen Dekkers wrote:
> Hi, 
> 
> the patch below implements IPv6 support for inetd, telnet and
> telnetd.  I also cleaned up telnet some bit, removing source routing
> (I don't think anyone allows you to do that nowadays) and code for
> some obsolete TOS interface.  If you've any questions about the
> patch, just ask. :)

I had a small problem with the patch against telnet (I haven't tested
the rest.) It always connects to port 23, no matter what port you give
it.

> +  telnetport = 0;
> +  if (portp && *portp == '-')
> +    {
> +      portp++;
> +      telnetport = 1;
> +    }
> +  else
> +    {
> +      telnetport = 1;
> +      portp = "telnet";
> +    }

The problem would appear to be here. Changing the else to "else if
(!portp)" seems to fix it.

Regards,

-- 
Göran Weinholt <address@hidden> - student/sysadmin/Debian developer
GPG: 1024D/4A8854E6 EC27 7F6A DFA9 CBBD 9EE3  F07A 8DF5 8BB6 4A88 54E6
"Science does not remove the terror of the Gods."  -- J.R. "Bob" Dobbs

signature.asc
Description: Digital signature