bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35175: Cannot reconfigure


From: Danny Milosavljevic
Subject: bug#35175: Cannot reconfigure
Date: Mon, 8 Apr 2019 12:54:14 +0200

On Sat, 06 Apr 2019 20:44:45 +0000
address@hidden wrote:

> This is not a bug, but your config is wrong here:
> 
>   (file-systems
>    (cons
>     (file-system (device "my-root")
>                (mount-point "/")
>                (type "ext4")
>                (title 'label))
>     %base-file-systems))
> 
> Delete string  `(title 'label)` and leave like this:
> 
>   (file-systems
>    (cons
>     (file-system (device "my-root")
>                (mount-point "/")
>                (type "ext4"))
>     %base-file-systems))

... why?

I use (title 'label) for more than a year and it works fine.

The reason for the error Luther encountered is because something is up with the 
gdm service.

And that's because of

                      (extend params (compose extensions)))

And I guess the extension/composition mechanism of gdm is broken.

There was a commit

commit 0cf981a6066711f6e830a3f1d40f7c265b0bac94
Author: Ludovic Courtès <address@hidden>
Date:   Fri Apr 5 17:40:01 2019 +0200

    services: gdm: Properly handle empty extensions lists.

recently.

The change is:

diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
index 26ca0d4f1f..ede8bc7304 100644
--- a/gnu/services/xorg.scm
+++ b/gnu/services/xorg.scm
@@ -879,11 +879,16 @@ the GNOME desktop environment.")
                 ;; For convenience, this service can be extended with an
                 ;; <xorg-configuration> record.  Take the first one that
                 ;; comes.
-                (compose first)
+                (compose (lambda (extensions)
+                           (match extensions
+                             (() #f)
+                             ((config . _) config))))
                 (extend (lambda (config xorg-configuration)
-                          (gdm-configuration
-                           (inherit config)
-                           (xorg-configuration xorg-configuration))))
+                          (if xorg-configuration
+                              (gdm-configuration
+                               (inherit config)
+                               (xorg-configuration xorg-configuration))
+                              config)))
 
                 (default-value (gdm-configuration))
                 (description

@Luther: Could you try with the commit right before that change?

  guix pull --commit=37aaf9a8c7d64ae69c4670a12f481dfc0aac53ae

Attachment: pgpj5kSSMT8eS.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]