From 583b0470f53a3ed707c3a809ac209747780fa490 Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Tue, 16 Apr 2024 20:21:04 -0700 Subject: [PATCH] gnulib-tool.py: Fix pylint 'attribute-defined-outside-init' warnings. * pygnulib/GLError.py (GLError.__init__): Define the 'messages' attribute to None. * pygnulib/GLImport.py (GLImport.__init__): Define the 'assistant' attribute to a GLFileAssistant object. * pygnulib/GLModuleSystem.py (GLModuleTable.transitive_closure): Don't define a 'modules' attribute since it is never used. --- ChangeLog | 10 ++++++++++ pygnulib/GLError.py | 1 + pygnulib/GLImport.py | 1 + pygnulib/GLModuleSystem.py | 1 - 4 files changed, 12 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index ffe35d5d1d..863a750109 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2024-04-16 Collin Funk + + gnulib-tool.py: Fix pylint 'attribute-defined-outside-init' warnings. + * pygnulib/GLError.py (GLError.__init__): Define the 'messages' + attribute to None. + * pygnulib/GLImport.py (GLImport.__init__): Define the 'assistant' + attribute to a GLFileAssistant object. + * pygnulib/GLModuleSystem.py (GLModuleTable.transitive_closure): Don't + define a 'modules' attribute since it is never used. + 2024-04-16 Sam James wchar: Fix serial number. diff --git a/pygnulib/GLError.py b/pygnulib/GLError.py index a990c382b1..fd7cb96975 100644 --- a/pygnulib/GLError.py +++ b/pygnulib/GLError.py @@ -68,6 +68,7 @@ def __init__(self, errno: int, errinfo: str | float | None = None) -> None: self.errno = errno self.errinfo = errinfo self.args = (self.errno, self.errinfo) + self.message = None def __repr__(self) -> str: errno = self.errno diff --git a/pygnulib/GLImport.py b/pygnulib/GLImport.py index c6a4693c90..a68399f561 100644 --- a/pygnulib/GLImport.py +++ b/pygnulib/GLImport.py @@ -304,6 +304,7 @@ def __init__(self, config: GLConfig, mode: int) -> None: self.emitter = GLEmiter(self.config) self.filesystem = GLFileSystem(self.config) self.modulesystem = GLModuleSystem(self.config) + self.assistant = GLFileAssistant(self.config) self.moduletable = GLModuleTable(self.config, self.config.checkInclTestCategory(TESTS['all-tests']), self.config.checkInclTestCategory(TESTS['all-tests'])) diff --git a/pygnulib/GLModuleSystem.py b/pygnulib/GLModuleSystem.py index 6aed38b9eb..40ac591dc4 100644 --- a/pygnulib/GLModuleSystem.py +++ b/pygnulib/GLModuleSystem.py @@ -913,7 +913,6 @@ def transitive_closure(self, modules: list[GLModule]) -> list[GLModule]: inmodules = sorted(set(inmodules)) inc_all_tests = self.inc_all_indirect_tests modules = sorted(set(outmodules)) - self.modules = modules return modules def transitive_closure_separately(self, basemodules: list[GLModule], -- 2.44.0