bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

all-modules: Fix warnings in --version output.


From: Collin Funk
Subject: all-modules: Fix warnings in --version output.
Date: Wed, 3 Apr 2024 18:02:15 -0700
User-agent: Mozilla Thunderbird

Running this script:

    $ ./all-modules --version
    ./all-modules: line 44: func_gnulib_dir: command not found
    sed: can't read /ChangeLog: No such file or directory
    ./all-modules: line 65: /build-aux/mdate-sh: No such file or directory
    all-modules (GNU gnulib )
    Copyright (C)  Free Software Foundation, Inc.
    License GPLv3+: GNU GPL version 3 or later 
<https://gnu.org/licenses/gpl.html>
    This is free software: you are free to change and redistribute it.
    There is NO WARRANTY, to the extent permitted by law.

    Written by Bruno Haible

The first patch copies the missing function from 'posix-modules'.

The date output in both of those scripts is incorrect for me:

    posix-modules (GNU gnulib 2024-04-04 00:00:00) 0.1.7344-83a61

I remember we addressed this when I first started working on the
Python version of gnulib-tool. There it caused an uncaught exception
because of an out of bounds index, instead of an incorrect time 
value. :)

The second patch just copies that change:

    git log ChangeLog

becomes:

    git log -n 1 --format=medium --date=iso ChangeLog

I *think* all 'git log' invocations should be safe now...

Collin

Attachment: 0001-all-modules-Fix-warnings-in-version-output.patch
Description: Text Data

Attachment: 0002-posix-modules-all-modules-Fix-version-output-using-g.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]