bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib-tool.py: Don't ignore the argument to --doc-base.


From: Bruno Haible
Subject: Re: gnulib-tool.py: Don't ignore the argument to --doc-base.
Date: Thu, 04 Apr 2024 01:00:18 +0200

Hi Collin,

> When building GNU PSPP I see this:
> 
> --- /home/collin/.local/src/pspp/gl/m4/gnulib-cache.m4        2024-04-02 
> 18:10:06.209522277 -0700
> +++ /home/collin/.local/src/glpyXBzSID/gl/m4/gnulib-cache.m4  2024-04-02 
> 18:09:37.828467148 -0700
> @@ -31,7 +31,7 @@
>  #  --lib=libgl \
>  #  --source-base=gl \
>  #  --m4-base=gl/m4 \
> -#  --doc-base=gl/doc \
> +#  --doc-base=doc \
>  #  --tests-base=tests \
>  #  --aux-dir=build-aux \
>  #  --makefile-name=automake.mk \
> @@ -302,7 +302,7 @@
>  gl_SOURCE_BASE([gl])
>  gl_M4_BASE([gl/m4])
>  gl_PO_BASE([])
> -gl_DOC_BASE([gl/doc])
> +gl_DOC_BASE([doc])
>  gl_TESTS_BASE([tests])
>  gl_LIB([libgl])
>  gl_MAKEFILE_NAME([automake.mk])
> 
> This patch fixes it. It seems that gnulib-tool.py never respected the
> directory passed with --doc-base.

Thanks! Applied. I think I will add a unit test for this one.

> PSPP doesn't use the bootstrap script, and running make without a
> target will fail with GNULIB_TOOL_IMPL=sh+py because of some *.png
> files.
> 
> This seems to work:
> 
>        env GNUMAKEFLAGS="" GNULIB_TOOL_IMPL=sh+py make -f Smake prep_ph

Thanks, this info will help me setting up the unit test.

Bruno






reply via email to

[Prev in Thread] Current Thread [Next in Thread]